slashing protection up to date for keys added mid run - #17411
Open
james-prysm wants to merge 6 commits into
Open
slashing protection up to date for keys added mid run#17411james-prysm wants to merge 6 commits into
james-prysm wants to merge 6 commits into
Conversation
Comment on lines
279
to
282
Contributor
There was a problem hiding this comment.
isn't this the problem? it's gonna return for remote keymanager, and we won't create the buckets. or am i missing sth?
Contributor
Author
There was a problem hiding this comment.
the buckets should create regardless of the type, the early return is just for the keymanager api.
also shouldn't this fix somethign for local keymanager type anyways?
Contributor
Author
There was a problem hiding this comment.
thinking about it more it probably makes sense not to have that check either....
Contributor
There was a problem hiding this comment.
what if an import happens before we reach this line of the goroutine? will we miss it until another account change?
Contributor
Author
There was a problem hiding this comment.
hmm there might be a race here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
recheckValidatingKeysBucket shouldn't only run when there is a UpdatePublicKeysBuckets failure, we need to run it regardless for keys added mid run
Which issue(s) does this PR fix?
related to #17408
Other notes for review
Acknowledgements