Revert "fix(elasticsearch): skip bootstrap-only checks when joining existing cluster (#149)"

[Oddly]

Reverts #149.

The block-level when: not elasticsearch_cluster_set_up | bool on the "Runtime cluster setup" block in elasticsearch-security.yml regresses fresh-install scenarios. The block contains an inner set_fact that flips elasticsearch_cluster_set_up to true partway through, after the initial passwords file is written. Ansible copies a block-level when onto every inner task and re-evaluates it against the current variable state, so every task after that internal set_fact silently skips — including Fetch elastic password after initial setup, which is what sets elasticstack_password. Downstream consumers (cluster settings, watermarks, the molecule shared set_ci_watermarks helper) then see elasticstack_password undefined and either fall back to a hardcoded path that doesn't exist for custom-path scenarios, or fail outright.

I caught this on a workflow_dispatch of Test Role elasticsearch against main after the merge: elasticsearch_custom, elasticsearch_cert_content, and elasticsearch_diagnostics failed at the watermark step on rocky9 + ES 9 (and debian13 for diagnostics). The same scenarios were green on the schedule run from yesterday, and main is exactly +2 commits since then (#147 + #149), confirming the regression source.

I'm reverting both files in #149 together. The main.yml master-count change isn't broken by itself, but it's only useful in combination with the join-existing-cluster path, so it goes back along with the security-tasks revert and returns in the follow-up PR.

A follow-up will replace this with task-level gating: add not elasticsearch_cluster_set_up | bool to the individual bootstrap-password tasks (Check for API with bootstrap password, the recovery sub-block, the Fail task, and Check for cluster status with bootstrap password) so they skip on a joining node without poisoning the inner set_fact. Reopens #148.

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Refined Elasticsearch cluster setup execution logic to respect system check mode
  • Simplified master-node validation to consistently enforce odd-count requirement for cluster stability

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fa30f7a4-5877-4fcf-867f-f40274e70b0f

📥 Commits

Reviewing files that changed from the base of the PR and between 39037c0 and 3821d12.

📒 Files selected for processing (2)

• roles/elasticsearch/tasks/elasticsearch-security.yml
• roles/elasticsearch/tasks/main.yml

---

📝 Walkthrough

Walkthrough

This PR removes conditional guards that depended on elasticsearch_cluster_set_up state from two task blocks. Master-node validation now enforces its odd-count constraint unconditionally, and runtime cluster setup execution now depends only on check-mode status rather than prior cluster setup completion.

Changes

Remove Cluster Setup State Guards

Layer / File(s)	Summary
Validation Constraints roles/elasticsearch/tasks/main.yml	Master-node count validation no longer skips when elasticsearch_cluster_set_up is true; the even-count failure condition now applies unconditionally.
Runtime Setup Conditions roles/elasticsearch/tasks/elasticsearch-security.yml	Runtime cluster setup block condition is simplified from when: not ansible_check_mode and not elasticsearch_cluster_set_up | bool to when: not ansible_check_mode.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

• Skip master-count and bootstrap-password checks when joining an existing cluster (elasticsearch_cluster_set_up=true) #148: Proposes adding elasticsearch_cluster_set_up guards to the same blocks that this PR removes them from—directly inverse relationship to these changes.

Possibly related PRs

• Oddly/elasticstack#147: Modifies how elasticsearch_cluster_set_up variable is set and used; these changes remove conditional dependencies on that variable.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert/149-bootstrap-checks-gating

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}