Make nearby pairing resilient across Windows interfaces - #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A physical laptop remained on "Looking for your main PC" even though the owner listener and private-network firewall rule were healthy. The old worker trusted Windows to choose one interface for global broadcast and multicast. VPN and virtual adapters can win that routing decision, hiding the real Wi-Fi or Ethernet LAN. The pre-authentication path also silently rejected clocks differing by more than 30 seconds.
User impact
The normal flow remains Find my fabric on the laptop and Add machine on the owner. Rampage now searches every active LAN path automatically, and incorrect device clocks cannot strand discovery or extend enrollment authority.
Validation
cargo fmt --all -- --checkcargo check --workspace --all-targetscargo test --workspace(22 desktop-native tests plus the full Rust campaign)cargo clippy --workspace --all-targets -- -D warningspnpm check(desktop 18, edge 2, TypeScript SDK 12; all builds)scripts/Assert-RampageVersion.ps1 -Tag v0.3.1(9 surfaces)scripts/Smoke-RampageInstaller.ps1: install/uninstall 0, six payloads, shortcuts verified, controller/intelligence ready, one signed node/offer, no leaked sidecarsPhysical two-machine pairing and Remote Assist remain explicitly pending the candidate-3 tag-bound package.