Group vite with its plugins so a coupled bump can install - #81
Open
Chris-ObtuseAI wants to merge 3 commits into
Open
Group vite with its plugins so a coupled bump can install#81Chris-ObtuseAI wants to merge 3 commits into
Chris-ObtuseAI wants to merge 3 commits into
Conversation
`@vitejs/plugin-react` 6.x requires `vite ^8.0.0`; this project is on
`vite ^6.3.5`. Bumped alone, the plugin dies at `npm ci` before any code
is compiled:
npm error ERESOLVE could not resolve
npm error While resolving: @vitejs/plugin-react@6.0.5
npm error Found: vite@6.4.3
So #72 was unmergeable by construction, not failing on anything in this
repository. Splitting a peer-coupled pair into separate pull requests can
only ever produce two branches that each fail.
This is the same failure the cargo section already documents for the
RustCrypto crates, and it takes the same remedy: one group, one atomic pull
request. The next attempt will carry vite and its plugins together, which
is also the only way the 6 -> 8 jump can be reviewed honestly -- as a
single build-tool upgrade with the UI build and browser tests run against
it, rather than as a plugin bump.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vitejs/plugin-react6.x requiresvite ^8.0.0; this project is onvite ^6.3.5. Bumped alone (#72), the plugin dies atnpm cibefore any code is compiled:So #72 is unmergeable by construction, not failing on anything in this repository. Splitting a peer-coupled pair into separate PRs can only ever produce branches that each fail.
This is the same failure the cargo section already documents for the RustCrypto crates, and it takes the same remedy: one group, one atomic pull request.
The next attempt will carry vite and its plugins together — which is also the only way the vite 6 → 8 jump can be reviewed honestly: as a single build-tool upgrade with the UI build and browser tests run against it, rather than as a plugin bump that happens to drag a build tool two majors forward.
Config parses clean:
🤖 Generated with Claude Code