fix(sell inference): emit registration spec + honor operator overrides

[bussyjd]

Summary

obol sell inference produced ServiceOffers that were silently missing the ERC-8004 registration block, so /.well-known/agent-registration.json was never routed for inference-typed sells. Surfaced today on spark2 while probing https://inference.v1337.org/.well-known/agent-registration.json — got the Traefik fall-through 404 with a Next.js HTML body. Manual kubectl patch enabled registration but exposed a second, controller-side defect where any operator-supplied description was clobbered on the way out.

Four related defects in one cohesive fix:

#	Layer	What
A	cmd/obol/sell.go sellInferenceCommand	No --register-* flags exposed
B	cmd/obol/sell.go buildInferenceServiceOfferSpec	Never wrote spec.registration; hardcoded spec.model.name="ollama" regardless of --model
C	cmd/obol/sell.go buildInferenceServiceOfferSpec call site	No plumbing from the operator's flags into the spec
D	internal/serviceoffercontroller/render.go	buildActiveRegistrationDocument unconditionally overwrote operator Spec.Registration.Description for inference offers

Test coverage that would have caught this

Adding tests was the asked-for half of the work — each one pins a specific defect so a regression has to fight every layer.

• TestSellInference_Flags now requires --no-register, --register-name, --register-description, --register-image, --register-skills, --register-domains, --register-metadata. Their absence on main was defect A.
• TestBuildInferenceServiceOfferSpec_RegistrationEnabledByDefault — defaults produce spec.registration.enabled = true and name = <offer name>.
• TestBuildInferenceServiceOfferSpec_NoRegisterOmitsRegistration — --no-register opt-out path.
• TestBuildInferenceServiceOfferSpec_OperatorOverridesWin — operator-supplied name/description/image/skills/domains all survive into spec.registration verbatim.
• TestBuildInferenceServiceOfferSpec_ModelNameNotHardcoded — spec.model.name reflects --model, not the historical "ollama" literal.
• TestBuildActiveRegistrationDocument_KeepsOperatorDescription — controller-side: operator description survives into the published AgentRegistration document (defect D).
• TestBuildActiveRegistrationDocument_FallsBackToModelDescriptionForInference — the other branch: empty operator description on inference offers still gets the model-aware default, not the generic one.

Run:

$ go test ./cmd/obol ./internal/serviceoffercontroller -count=1
ok  cmd/obol  3.624s
ok  internal/serviceoffercontroller  10.259s

Reverse-validation that the tests catch the bugs

Each new test maps to a specific line that was wrong on main:

• The flag-list assertion fails before adding cmd/obol/sell.go:188–216 (the new flag block).
• The _RegistrationEnabledByDefault / _OperatorOverridesWin tests fail before changing buildInferenceServiceOfferSpec's signature to accept the registration map.
• The _ModelNameNotHardcoded test fails on the name: "ollama" literal at the old line.
• The controller test fails on the if owner.IsInference() && owner.Spec.Model.Name != "" unconditional overwrite at render.go:589.

Drive-by

TestSellInference_Flags was already failing on main after #470 removed the --price default but didn't update the assertStringDefault(t, flags, "price", "0.001") assertion. Bumped to assert "" with a comment explaining the post-#470 contract. Not the headline fix but rolling it in keeps make test green.

Notes for the reviewer

• The rename sellHTTPRegistrationInput → sellRegistrationInput (and the matching helper) is mechanical and contained: only sell.go + sell_test.go reference these names. Did it because the helper is now shared between inference and http call sites.
• Live end-to-end validation on spark2 was attempted; the dev k3d cluster had wound down between checks. The unit-test coverage above pins the three layers independently; happy to re-do the live test against a refreshed cluster if reviewers want belt-and-suspenders.

Generated with Claude Code

[bussyjd]

Superseded by #487 — all three commits (4708407, b92b78e, dbf6c89) folded into the umbrella branch verbatim, plus the resume + storefront work that grew out of them. Reviewing #487 reviews these changes too.