Security architecture skill - #22
Open
eoftedal wants to merge 2 commits into
Open
Conversation
|
Thanks for pulling AISVS into the skill data, it's a useful grounding source. One correctness issue worth fixing before merge: the bundled AISVS chapters under plugins/code-security-skills/data/aisvs/ are from a pre-v1.0 draft, and the mismatch runs across the whole set, not just one chapter. Released AISVS v1.0 (June 2026) renumbered and restructured the chapters, so by-number citations from these skills will point at the wrong control. Checked against released v1.0 (OWASP/AISVS, 1.0/en/):
Since the skill's value is OWASP-grounded traceability, recommend re-syncing the entire data/aisvs/ set from the 1.0/en source before merge, so the chapter numbers and control IDs match the released standard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill to describe the application and it's security properties (not vulnerability/weakness focused - purely a descriptive skill)