test: bootstrap DB props in DowngradeAdminsIT and DeletePlayersIT

[ismisepaul]

Summary

Two IT files under src/it/java/servlets/admin/userManagement/ were calling into Getter/Setter without first writing the test database.properties file. The other 42 IT files in the suite do this via a standard @BeforeAll block. These two were missed.

Pre-pool (#816) this worked: application code read the properties file lazily on every DB call, and the test runtime arranged for the file to exist via other means.

Post-pool, ConnectionPool.initialize() runs once per JVM on the first getConnection() call and reads the props file exactly once. If the file is missing, the pool is marked unusable for the entire JVM and every subsequent test in that fork throws Connection pool not available.

In CI this looked like a flood of FATAL FileNotFoundException stack traces drowning out the actual leak signal we're hunting in the integration-tests job. Example seen on the post-#834 dev#536 run:

FileNotFoundException: /home/runner/.../target/test-classes/conf/database.properties (No such file or directory)
  at ConnectionPool.loadDatabaseProperties(ConnectionPool.java:257)
  at ConnectionPool.initialize(ConnectionPool.java:73)
  ...
  at servlets.admin.userManagement.DowngradeAdminsIT.testWithAdminAuthValidUser

Attribution

This is a latent IT-bootstrap gap that #816's pool-init model surfaced, not a regression from any specific recent PR:

• feat: add connection pooling to fix db connection exhaustion (#536) #816 changed pool init from per-call (lazy file read) to per-JVM (one-shot file read).
• fix: migrate all integration tests to JUnit 5 and fix revealed failures #826 (JUnit 4 → 5 migration) preserved the pre-existing setup verbatim; didn't touch this.
• perf: DDL once + per-class data reseed for integration tests (#831) #832 (DDL once / per-class reseed) updated 35 ITs that already had the bootstrap; didn't add it to ITs that lacked it.

A strategic fix would be to make TestProperties auto-bootstrap on any first DB call from a test JVM, but that is much bigger scope than needed.

Changes

File	Change
DowngradeAdminsIT.java	Add @BeforeAll resetDatabase() with createMysqlResource + ensureSchemaReady + reseedTestData. Keep existing @BeforeEach (per-test mock request/response reset).
DeletePlayersIT.java	Same.

26 lines added across the two files. No behavior change beyond the bootstrap.

Verification

mvn -Dit.test='DowngradeAdminsIT,DeletePlayersIT' failsafe:integration-test
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0

All 8 tests now pass (4 per file). Before this fix every one of them FATAL'd at pool init.

Why this matters now

After #834 and #836 closed the high-impact core-pool leaks in Setter and Setup, the integration-tests job on dev#536 still failed — but with two distinct failure modes interleaved:

1. Real remaining leaks in challenge servlets / other paths (the actual signal).
2. This IT-bootstrap bug producing hundreds of lines of FATAL log per failing test method (noise).

Removing the noise lets us see which challenge family to tackle next.

Test plan

• Local: 8 tests pass across both files
• CI integration-tests run cleaner (no Connection pool not available cascade from these two classes)

[Copilot]

Pull request overview

Adds the standard integration-test database bootstrap to two previously-missed servlet IT classes so the test database.properties exists before any Getter/Setter DB call triggers one-shot ConnectionPool.initialize().

Changes:

• Added a @BeforeAll resetDatabase() block to DowngradeAdminsIT to create the MySQL test properties resource and reseed the DB.
• Added the same @BeforeAll resetDatabase() block to DeletePlayersIT.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/it/java/servlets/admin/userManagement/DowngradeAdminsIT.java	Adds @BeforeAll DB/property bootstrap (create MySQL resource, ensure schema, reseed) to prevent pool init failures when this class runs early in a fork.
src/it/java/servlets/admin/userManagement/DeletePlayersIT.java	Same @BeforeAll bootstrap to ensure database.properties exists before any DB access.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.