Add input guards to fortio_fread_buffer for parity with resdata PR #1189#14208
Merged
Conversation
Reject null buffers and negative buffer sizes up front, returning false instead of risking a null dereference or hitting util_abort. The buffer-overflow protection from the upstream fix is already present via #14144; these two input-validation guards are the remaining delta.
jonjenssen
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two input-validation guards to
fortio_fread_bufferin ResInsight's vendored copy of resdata (ThirdParty/Ert/lib/ecl/fortio.c), for parity with upstream resdata PR equinor/resdata#1189 ("Fix validation of record_size in fortio_fread_buffer").The function now rejects a null
buffer(with non-zero size) and a negativebuffer_sizeup front, returningfalseinstead of risking a null dereference or falling through toutil_abort.ResInsight carries an older fork of resdata, so the upstream rewrite cannot be applied verbatim. The core buffer-overflow protection from the upstream fix is already present in this fork via #14144 ("Guard against buffer overflow when reading corrupt well data records"); these two input-validation guards are the only remaining delta.