Bugfix: maximum pore size #113
Merged
diogosiebert merged 1 commit intoOPM:devfrom Apr 21, 2026
Merged
Conversation
…tead of maxReduce, leading to the wrong maximum pore size in the sample which was also dependent on the number of tasks used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small bug where the maximum distance was computed using sumReduce rather than maxReduce. As a result, the reported maximum pore size for the sample was incorrect and varied with the number of tasks used.
Because both the bug and the fix are very clear, I’m submitting this directly as a PR for the record.