fix(cpp): out-of-bounds read in delete() when a location is passed#404
Closed
pbbadenhorst wants to merge 1 commit into
Closed
fix(cpp): out-of-bounds read in delete() when a location is passed#404pbbadenhorst wants to merge 1 commit into
pbbadenhorst wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing, see #405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
deleteJSI host function in cpp/DBHostObject.cpp checkscount == 1for the optional location argument, but then readsargs[1]instead ofargs[0]. Callingdb.delete(location)therefore reads past the end of the JSI argument list — undefined behaviour, can crash native code.Also fixes a stale error string in the same block that referred to
[op-sqlite][open]instead of[op-sqlite][delete].Changes
cpp/DBHostObject.cpp: useargs[0]for the optional location argument; correct the error message tag.example/src/tests/dbsetup.ts: add two regression tests — one that callsdb.delete(location)with a valid string, and one that asserts a non-string argument is rejected by the type guard.