test(parity): compare against oold-js instead of oold-schema's scripts - #144
Merged
Conversation
The reference implementation moved to OO-LD/oold-js, so the corpus and the implementation checking it are now separate checkouts: OOLD_SCHEMA_DIR for the examples and meta-schemas, OOLD_JS_DIR for the reference. CI pins the reference by tag and leaves the corpus tracking main, so a reference change is adopted deliberately while a specification change is still noticed on the next run. Closes #136
Contributor
Release previewNo version bump from the current commits (stays at Changelog preview (truncated)Preview via python-semantic-release and conventional commits. |
Contributor
📊 Benchmark ResultsClick to see benchmark comparisonThreshold: 1.3x (30% slower triggers a regression warning) Note: Benchmarks are informational only and won't fail the build. 💡 Tip: Download the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136. Pairs with OO-LD/oold-schema#156, which removes the scripts this stops pointing at.
validate.mjs,schema_to_frame.mjsandpattern_lint.mjsnow live in OO-LD/oold-js, extracted unchanged and taggedv0.1.0.Change
reference_dirfixture readingOOLD_JS_DIR, alongsideupstream_dirforOOLD_SCHEMA_DIR. The corpus and the reference are different repositories now and a machine can have either without the other.referencefixture runs the validator and bothsubprocesscall sites collapse into it. It passes--meta <corpus>/meta, so both implementations read one file set and a disagreement can only come from the code -oold-jsvendors no meta-schemas.oold-jsat a pinned tag andnpm cis it. The corpus stays onmain: pinning the reference makes a change to it deliberate, while leaving the corpus moving is what lets parity notice a specification change the fixture snapshot cannot.CLAUDE.md,docs/architecture.mdanddocs/how-to/validation.mdupdated; the pin they cited (validate.mjsatv1.0.0-rc.2) no longer exists.Without
OOLD_JS_DIRthe two verdict-comparing tests skip and the four corpus-only tests still run.Verification
OOLD_SCHEMA_DIRonly: 4 passed, 2 skipped, namingOOLD_JS_DIRin the skip reasonpytest: 565 passed, 9 skippedmake docs-test: no issues