[19.0][FIX] base_tier_validation: bypass approval only for consecutive tiers#36
Open
bosd wants to merge 1 commit into
Open
[19.0][FIX] base_tier_validation: bypass approval only for consecutive tiers#36bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
OCA-git-bot
added
mod:base_tier_validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port of OCA/server-ux#1141 (authored by @Saran440 / Ecosoft) onto 19.0.
approve_sequence_bypassis supposed to skip a tier's approval only when the previous (consecutive) tier was already validated by the same reviewer. The current logic instead bypasses whenever the same reviewer appears anywhere in the earlier tiers — even with gaps. With multi-tier workflows where the same person sits on tier 1 and tier 3 but a third party owns tier 2, that lets the workflow auto-approve tier 3 the moment tier 1 is signed, before tier 2 even gets a chance.This forward-port restricts the bypass to the immediately previous sequence so non-consecutive overlaps no longer auto-approve.
Credit
Original commit:
48049458by @Saran440 / Ecosoft. Cherry-picked unchanged onto 19.0; the surrounding code was identical to 18.0 so no resolution was needed.