Skip to content

[17.0][IMP] fs_attachment_s3: Optimize clean up storages using mass deletion#599

Open
peluko00 wants to merge 1 commit into
OCA:17.0from
APSL:17.0-imp-fs_attachment_s3
Open

[17.0][IMP] fs_attachment_s3: Optimize clean up storages using mass deletion#599
peluko00 wants to merge 1 commit into
OCA:17.0from
APSL:17.0-imp-fs_attachment_s3

Conversation

@peluko00
Copy link
Copy Markdown

@peluko00 peluko00 commented Apr 28, 2026

Optimize clean up storages using mass deletion with S3
cc https://github.com/APSL 38655
@mpascuall @BernatObrador @ppyczko @shirashi3771 @palomagrc93 @miquelalzanillas @LlucSG please review

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@peluko00 peluko00 force-pushed the 17.0-imp-fs_attachment_s3 branch 3 times, most recently from a596bc5 to b858c7d Compare April 29, 2026 07:36
Comment thread fs_attachment_s3/readme/CONTRIBUTORS.md Outdated
Comment on lines +3 to +4
- [APSL-Nagarro](https://apsl.tech):
- Antoni Marroig \<<amarroig@apsl.net>\>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to follow the same pattern as for others contributors ;-)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Copy Markdown
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @peluko00 The code looks good to me.

@peluko00 peluko00 force-pushed the 17.0-imp-fs_attachment_s3 branch from b858c7d to 964ac2f Compare May 11, 2026 08:36
Copy link
Copy Markdown
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed. LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@peluko00
Copy link
Copy Markdown
Author

Seems it's ready for merge @lmignon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants