Skip to content

[19.0][MIG] fetchmail_notify_error_to_sender: Migration to 19.0#3604

Draft
CRogos wants to merge 29 commits into
OCA:19.0from
c4a8-odoo:copilot/migrate-fetchmail-notify-error-to-sender
Draft

[19.0][MIG] fetchmail_notify_error_to_sender: Migration to 19.0#3604
CRogos wants to merge 29 commits into
OCA:19.0from
c4a8-odoo:copilot/migrate-fetchmail-notify-error-to-sender

Conversation

@CRogos
Copy link
Copy Markdown
Contributor

@CRogos CRogos commented Apr 23, 2026

@NICO-SOLUTIONS could you test?

eLBati and others added 29 commits April 23, 2026 14:48
* [FIX] auth_from_http_remote_user - Lint

* [FIX] server_environment - Lint

* [FIX] base_module_doc_rst - Lint

* [FIX] fetchmail_notify_error_to_sender - Fix XML view, it was the 'active' field from 'fetchmail_attach_from_folder' module which was targeted by mistake (belonging to another data model)
Currently translated at 100.0% (6 of 6 strings)

Translation: server-tools-12.0/server-tools-12.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-fetchmail_notify_error_to_sender/zh_CN/
Currently translated at 100.0% (6 of 6 strings)

Translation: server-tools-12.0/server-tools-12.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-fetchmail_notify_error_to_sender/pt_BR/
[FIX] fetchmail_notify_error_to_sender: Bug fix flake8

[FIX] fetchmail_notify_error_to_sender: Bug fix flake8
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-15.0/server-tools-15.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-fetchmail_notify_error_to_sender/es_AR/
Currently translated at 44.4% (4 of 9 strings)

Translation: server-tools-15.0/server-tools-15.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-fetchmail_notify_error_to_sender/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-15.0/server-tools-15.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-fetchmail_notify_error_to_sender/es_AR/
Currently translated at 100.0% (12 of 12 strings)

Translation: server-tools-15.0/server-tools-15.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-fetchmail_notify_error_to_sender/es_AR/
Currently translated at 100.0% (12 of 12 strings)

Translation: server-tools-15.0/server-tools-15.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-fetchmail_notify_error_to_sender/es/
[FIX] Changed depends module

Added test scripts

Updated test scripts
Currently translated at 100.0% (12 of 12 strings)

Translation: server-tools-18.0/server-tools-18.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-fetchmail_notify_error_to_sender/it/
Currently translated at 100.0% (12 of 12 strings)

Translation: server-tools-18.0/server-tools-18.0-fetchmail_notify_error_to_sender
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-fetchmail_notify_error_to_sender/de/
@OCA-git-bot OCA-git-bot added the mod:fetchmail_notify_error_to_sender Module fetchmail_notify_error_to_sender label Apr 23, 2026
@NICO-SOLUTIONS
Copy link
Copy Markdown
Member

@CRogos
In current Odoo versions, message_route() no longer reliably raises a ValueError for routing failures, as unmatched routing cases are handled internally via the catchall/fallback mechanism.
This means the exception-based hook used here is effectively not triggered anymore in most real scenarios, so the notification logic is likely inactive in practice.

If the goal is to handle emails sent to the catchall address without a matching alias, this would require a different approach than relying on ValueError, since it is no longer a reliable signal.
Instead, one would need to hook into the routing result or extend the catchall processing flow.

Alternatively, this might already be better addressed on Odoo side: the default notification email is a bit misleading, as it suggests the catchall is only for replies, even when emails are sent to unknown aliases. Adjusting that wording could improve clarity without additional custom logic.

@CRogos CRogos marked this pull request as draft April 24, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:fetchmail_notify_error_to_sender Module fetchmail_notify_error_to_sender series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.