Skip to content

[18.0] [FIX] report_substitute: account.move.send.wizard report substitution - #1149

Open
amkarthik wants to merge 1 commit into
OCA:18.0from
sodexis:18.0-fix_report_substitute
Open

[18.0] [FIX] report_substitute: account.move.send.wizard report substitution#1149
amkarthik wants to merge 1 commit into
OCA:18.0from
sodexis:18.0-fix_report_substitute

Conversation

@amkarthik

Copy link
Copy Markdown
Member

Issue Description:
When sending emails from invoices, the substitution rules are not being applied as expected.

Resolution:
This PR addresses and resolves the issue by ensuring that the substitution rules are correctly applied during email generation from invoices.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@SodexisTeam
SodexisTeam force-pushed the 18.0-fix_report_substitute branch from 14a5f23 to bd66fa5 Compare March 24, 2026 11:33

@atchuthan atchuthan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atangaraj atangaraj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that with this change the substitution are not ran 2 times in nomale cases? A first time in the _pre_render phase and a second time at _render?

@HviorForgeFlow HviorForgeFlow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amkarthik can you attend comment #1149 (review)

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants