[19.0][MIG] project_task_code: Migration to 19.0 by Kiplangatdan · Pull Request #1667 · OCA/project

Kiplangatdan · 2026-02-11T15:08:28Z

No description provided.

luisDIXMIT

Code review and tested on runboat, LGTM! Only one minnor suggestion.

CristianoMafraJunior · 2026-02-18T11:56:35Z

76549cb @Kiplangatdan The name of this commit should be: [MIG] project_task_code: migrate to 19.0

alexey-pelykh

Clean migration with proper hooks. LGTM

OCA-git-bot · 2026-02-28T16:37:20Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2026-02-28T16:37:21Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2026-02-28T16:37:25Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

alexey-pelykh

Good migration overall -- the module correctly adopts Odoo 19.0 patterns (models.Constraint, @api.model_create_multi, _rec_names_search, BaseCommon in tests). A couple of minor observations below.

Observations:

Unused PROJECT_TASK_WRITABLE_FIELDS (models/project_task.py): The set PROJECT_TASK_WRITABLE_FIELDS = {"code"} is defined at module level but never referenced anywhere in this module. If this is intended for portal write access (as seen in some Odoo core patterns), the integration with project's WRITABLE_FIELDS would need to be wired up. Otherwise it is dead code.
.pot file version (i18n/project_task_code.pot): The Project-Id-Version header says Odoo Server 18.0 -- should be 19.0 to match the target branch. This is cosmetic and typically auto-regenerated by oca-gen-addon-readme, so not blocking.
Redundant search filter_domain (views/project_view.xml): The search view overrides the name field's filter_domain to include code in the search. However, _rec_names_search = ["name", "code"] on the model already handles name_search lookups covering both fields. The XML filter_domain is for the search bar in list/kanban views specifically, so both are actually needed for complete coverage -- this is correct as-is.

Already approved in a previous review. These observations are non-blocking.

Review posted via CorporateHub OCA review campaign

OCA Transbot updated translations from Transifex [MIG] project_task_code: Migrate to 10.0 Edit init and XML Add env Change task_ids to tasks Change to @api.multi before def copy

Relational fields and the task notification email inform the task code

The overload of project.task::create in the project_task_code would mutate the dictionaries passed in the vals_list argument. This is a bad practice which can have unintended side effects in caller code. We fix this by creating a new dictionary containing the additional field value and passing this dictionary in the call to super().create()

…olates not-null constraint

Currently, the sequence that generates task codes is only available for the main company [1], which could cause issues at the moment of the installation process with another modules in multi-companies cases, for example project_timesheet_holiday [2] because in the other companies, this line [3] will return False or "/" and will trigger the UNIQUE constraint. With this change, the sequence can be used by any company [4] using the False value in the field company_id. References: [1] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L148 [2] https://github.com/odoo/odoo/blob/7b6c25e/addons/project_timesheet_holidays/models/res_company.py#L14 [3] https://github.com/OCA/project/blob/9d08f2d/project_task_code/models/project_task.py#L29 [4] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L282

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/

Search task by its code in x2m fields.

tasks created from Portal

AaronHForgeFlow

Functional ok! just a minor comment.

AaronHForgeFlow · 2026-04-21T14:14:59Z

+        <field name="inherit_id" ref="project.view_task_search_form" />
+        <field name="arch" type="xml">
+            <field name="name" position="attributes">
+                <attribute name="filter_domain">['|', ('name', 'ilike', self),


maybe this is not neede if we add the _rec_names_search parameter on the model.

Kiplangatdan changed the title ~~[19.0][MIG] project_task_code~~ [19.0][MIG] project_task_code: Migration to 19.0 Feb 11, 2026

Kiplangatdan force-pushed the 19.0-mig-project-task-code branch from a1cf349 to dab13dd Compare February 11, 2026 15:33

luisDIXMIT approved these changes Feb 13, 2026

View reviewed changes

Comment thread project_task_code/__manifest__.py Outdated

Kiplangatdan force-pushed the 19.0-mig-project-task-code branch 2 times, most recently from 166e862 to 76549cb Compare February 18, 2026 08:29

Kiplangatdan force-pushed the 19.0-mig-project-task-code branch from 76549cb to baeba83 Compare February 18, 2026 15:03

alexey-pelykh approved these changes Feb 28, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 28, 2026

alexey-pelykh reviewed Mar 2, 2026

View reviewed changes

Comment thread project_task_code/models/project_task.py Outdated

Comment thread project_task_code/i18n/project_task_code.pot Outdated

oihane and others added 16 commits March 12, 2026 09:34

[MOD] changing from odoomrp to avanzosc

6bfe8c5

[FIX] Code error when copying a task

5c73a63

[IMP] <project_task_code> adapted to OCA

4f45d27

[IMP] <project_task_code> Added docstring to pre and post init-hooks

866e69d

[UPD] prefix versions with 8.0

ba916ab

[MIG] Make modules uninstallable

58f4945

[MIG] Rename manifest files

0f23cbc

project_task_code module

9fa395c

[MIG] project_task_code: Migrate to 10.0

85d1497

OCA Transbot updated translations from Transifex [MIG] project_task_code: Migrate to 10.0 Edit init and XML Add env Change task_ids to tasks Change to @api.multi before def copy

Requested README changes

19a944b

Requested XML change

0345c1d

OCA Transbot updated translations from Transifex

ce54598

[MIG] project_task_code: Migration to 11.0

acce182

[IMP] Implements name_get() in 'project.task'

3da5347

Relational fields and the task notification email inform the task code

remove obsolete .pot files [ci skip]

6f501d9

[UPD] Update project_task_code.pot

cfa50a6

gurneyalex and others added 25 commits March 12, 2026 09:34

[15.0][FIX] project_task_code: Fix null value in column code, that vi…

6d0531f

…olates not-null constraint

[IMP] update dotfiles [ci skip]

c01d5ba

[MIG] project_task_code: Migration to 16.0

9c25760

[FIX] project_task_code: unique code in company

fce4b7d

Update translation files

3820a2b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/

Translated using Weblate (Italian)

8e18f0e

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/

Translated using Weblate (Spanish)

d4257df

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/

Translated using Weblate (Spanish (Argentina))

30548d3

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/

[16.0][FIX]project_task_code: fix view kanban

c38dcfb

Translated using Weblate (Italian)

bca6506

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/

Translated using Weblate (Portuguese (Brazil))

e714ce5

Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/

[IMP] project_task_code Search by code in x2m

db5cfc7

Search task by its code in x2m fields.

[IMP] project_task_code: pre-commit auto fixes

8a5b0c0

[MIG] project_task_code: Migration to 17.0

d2ebba8

[IMP] project_task_code: pre-commit auto fixes

acfab4d

[IMP] project_task_code: pre-commit stuff

0f892f9

[MIG] project_task_code: Migration to 18.0

82381e4

[MIG] project_task_code: Finish Migration

1e56b13

[UPD] Update project_task_code.pot

6ac2de0

[BOT] post-merge updates

2a7c3ac

[FIX] project_task_code: Need to create sequences using sudo for

566f607

tasks created from Portal

[BOT] post-merge updates

7419505

[IMP] project_task_code: pre-commit auto fixes

75f4b10

Kiplangatdan force-pushed the 19.0-mig-project-task-code branch from baeba83 to e3e51af Compare March 12, 2026 06:35

[MIG] project_task_code: migrate to 19.0

08fd274

Kiplangatdan force-pushed the 19.0-mig-project-task-code branch from e3e51af to 08fd274 Compare March 12, 2026 06:39

AaronHForgeFlow reviewed Apr 21, 2026

View reviewed changes

AaronHForgeFlow mentioned this pull request Apr 21, 2026

[19.0][ADD] project_task_code_by_project #1707

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] project_task_code: Migration to 19.0#1667

[19.0][MIG] project_task_code: Migration to 19.0#1667
Kiplangatdan wants to merge 61 commits intoOCA:19.0from
Kiplangatdan:19.0-mig-project-task-code

Kiplangatdan commented Feb 11, 2026

Uh oh!

luisDIXMIT left a comment

Uh oh!

Uh oh!

CristianoMafraJunior commented Feb 18, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

Uh oh!

Uh oh!

AaronHForgeFlow left a comment

Uh oh!

AaronHForgeFlow Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Kiplangatdan commented Feb 11, 2026

Uh oh!

luisDIXMIT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CristianoMafraJunior commented Feb 18, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

OCA-git-bot commented Feb 28, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants