[18.0][MIG] project_status: Migration to 18.0

[Ricardo-MC]

No description provided.

[AaronHForgeFlow]

I have this error in runbot when accessing any project:

  File "/mnt/data/odoo-addons-dir/project_status/models/project.py", line 13, in _read_group_status_ids
    env["project.status"].with_user(SUPERUSER_ID)._search(domain, order=order)
  File "/opt/odoo/odoo/models.py", line 5814, in _search
    query.order = self._order_to_sql(order, query)
  File "/opt/odoo/odoo/models.py", line 5600, in _order_to_sql
    self._check_qorder(order)
  File "/opt/odoo/odoo/models.py", line 5566, in _check_qorder
    if not regex_order.match(word):
TypeError: expected string or bytes-like object

[Ricardo-MC]

@AaronHForgeFlow,
Thank you for the feedback!
You are right, the error occurs because order is not always a string.
I will update the code to check if order is a string, and if not, set it to "" before passing it to _search:
This will prevent the TypeError and make the method robust for all internal Odoo calls.
Let me know if you have any other suggestions!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[leemannd]

/ocabot migration project_status

[CristianoMafraJunior]

LGTM

[leemannd]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1555-by-leemannd-bump-nobump, awaiting test results.

[OCA-git-bot]

@leemannd your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1555-by-leemannd-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[alexey-pelykh]

Thanks for the migration, looks good overall.

CI is green on the PR branch. The merge-attempt failure (project_assignment / project_sequence unique constraint violations) is unrelated to this module -- likely a transient conflict with other modules being merged in parallel.

The codecov/project failure is a repo-wide coverage threshold, not specific to this PR.

Code-wise, everything is clean for 18.0:

• _read_group_status_ids signature is correct for the new group_expand callback API
• Security rules and multi-company support are properly implemented
• Views use appropriate 18.0 XML patterns
• Tests cover the core flow and exercise _read_group_status_ids directly

One minor observation (non-blocking): using ir.sequence for status_sequence ordering is a bit unconventional compared to a plain integer field with drag-to-reorder, but it works fine as-is.

Ready to merge once the unrelated CI conflict is resolved (re-trigger the merge command should be enough).

[BhaveshHeliconia]

Functional review LGTM

[leemannd]

/ocabot rebase

[OCA-git-bot]

@leemannd The rebase process failed, because command git push --force Ricardo-MC tmp-pr-1555:18.0-mig-project_status failed with output:

remote: Permission to Ricardo-MC/project.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Ricardo-MC/project/': The requested URL returned error: 403

[Ricardo-MC]

Hi @leemannd, could you try the merge again please

[leemannd]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1555-by-leemannd-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at ea65b6a. Thanks a lot for contributing to OCA. ❤️