Skip to content

[17.0][ADD]mail_notify_employee_leave#156

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
ForgeFlow:17.0-add-mail_noify_employee_leave
May 11, 2026
Merged

[17.0][ADD]mail_notify_employee_leave#156
OCA-git-bot merged 1 commit into
OCA:17.0from
ForgeFlow:17.0-add-mail_noify_employee_leave

Conversation

@GuillermoNforgeflow
Copy link
Copy Markdown

@GuillermoNforgeflow GuillermoNforgeflow commented Feb 26, 2026

This module automatically notifies users when they mention or assign a colleague who is out of office. The notification includes the expected return date of the absent user and is sent only once per day per user.

@GuillermoNforgeflow GuillermoNforgeflow changed the title [ADD]mail_notify_employee_leave [17.0][ADD]mail_notify_employee_leave Feb 26, 2026
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch 2 times, most recently from a07e0f3 to ed43a5c Compare February 27, 2026 12:38
@GuillermoNforgeflow GuillermoNforgeflow marked this pull request as ready for review February 27, 2026 12:40
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch 2 times, most recently from acdda41 to e90ac57 Compare March 5, 2026 11:09
Copy link
Copy Markdown

@AndreuOForgeFlow AndreuOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Comment thread mail_notify_employee_leave/models/mail_thread.py Outdated
Comment thread mail_notify_employee_leave/models/hr_employee.py
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch 4 times, most recently from 63cde2e to aeced1b Compare March 10, 2026 07:01
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch 2 times, most recently from 9d30768 to 12ac186 Compare April 1, 2026 06:46
Copy link
Copy Markdown
Contributor

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem to work for me:

  1. I create a time off for marc demo starting from today (24/4) and finishing next tuesday.
  2. I validate the time off
  3. I send a message to marc demo
Image
  1. I don't receive any reponse
Image

am i doing something wrong?

Comment thread mail_notify_employee_leave/models/hr_leave.py Outdated
Comment thread mail_notify_employee_leave/models/mail_thread.py Outdated
Comment thread mail_notify_employee_leave/tests/test_mail_notify_employee_leave.py Outdated
Comment thread mail_notify_employee_leave/models/mail_thread.py Outdated
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch from 12ac186 to c75c785 Compare April 28, 2026 10:06
@OCA-git-bot OCA-git-bot added series:17.0 mod:mail_notify_employee_leave Module mail_notify_employee_leave labels Apr 28, 2026
@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch from c75c785 to 74aa648 Compare April 28, 2026 11:53
Copy link
Copy Markdown
Contributor

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏿 functional and code review

@AndreuOForgeFlow
Copy link
Copy Markdown

Hi @pedrobaeza, could we perhaps merge this one?

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@GuillermoNforgeflow GuillermoNforgeflow force-pushed the 17.0-add-mail_noify_employee_leave branch from 74aa648 to 34e2caf Compare May 11, 2026 06:20
@GuillermoNforgeflow
Copy link
Copy Markdown
Author

Hi @pedrobaeza, could we merge this one again?

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-156-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4488cdf into OCA:17.0 May 11, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ef89f0b. Thanks a lot for contributing to OCA. ❤️

@GuillemCForgeFlow GuillemCForgeFlow deleted the 17.0-add-mail_noify_employee_leave branch May 11, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants