[16.0][IMP] base_geoengine: Avoid error seen clicking on RecordPanel#454
[16.0][IMP] base_geoengine: Avoid error seen clicking on RecordPanel#454anusriNPS wants to merge 1 commit into
Conversation
|
pre-commit fails which requires #442 to be merged which helps to update template |
anusriNPS
force-pushed
the
16.0-enhance-geoengine
branch
from
bab27b0 to
da82969
Compare
HekkiMelody
left a comment
HekkiMelody
left a comment
There was a problem hiding this comment.
Code review. Please specify in the first message that this PR depends on #417
| this.env._t( | ||
| "Please update latitude and longitude details for: " + | ||
| record.data.display_name | ||
| ), |
There was a problem hiding this comment.
chore: This will not work for translations, only literal strings can be translated
https://www.odoo.com/documentation/18.0/developer/howtos/translations.html
Can you test formatting it like this to see if it's exported properly in the .pot file?
There was a problem hiding this comment.
Updated pot files for newly introduced notification as part of the PR and translations are working as expected
| onDisplayPopupRecord(record) { | ||
| const popup = this.getPopup(); | ||
| const feature = this.vectorSource.getFeatureById(record.resId); | ||
| if (feature === null) { |
There was a problem hiding this comment.
question: this if can probably replace the other if at line 588
for example
if (feature) {
...
return false;
}
this.mountGeoengineRecord({
...What do you think?
There was a problem hiding this comment.
Agree, the new if block is sufficient and hence removed if block which checks for feature is not undefined.
anusriNPS
force-pushed
the
16.0-enhance-geoengine
branch
from
da82969 to
005a243
Compare
When a record in record panel does not contain latitude and longitude details, it fails with error "feature is null". Avoiding this error and notifying the user to update required details to view the record.
anusriNPS
force-pushed
the
16.0-enhance-geoengine
branch
from
005a243 to
082ec56
Compare
4 participants
Depends on #417. When a record in record panel does not contain latitude and
longitude details, it fails with error "feature is null". So, avoiding this error and notifying the user to update required details to view the record.
Below is the error seen without latitude and longitude details: