Skip to content

[18.0] [IMP] contract_brand: add unit test case#284

Open
marielejeune wants to merge 1 commit into
OCA:18.0from
acsone:18.0-fix_contract_brand_analytic_distribution-mle
Open

[18.0] [IMP] contract_brand: add unit test case#284
marielejeune wants to merge 1 commit into
OCA:18.0from
acsone:18.0-fix_contract_brand_analytic_distribution-mle

Conversation

@marielejeune
Copy link
Copy Markdown
Contributor

@marielejeune marielejeune commented Dec 4, 2025 •
edited
Loading

This PR originally fixed a problem on contract_brand when combining analytic distribution defined by analytic distribution models with analytic on brands.

However with PR #286 and the refactoring on analytic on brands this fix was covered.

This PR just adds the unit test case to ensure a non-regression.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 4, 2025

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@pcastelovigo pcastelovigo mentioned this pull request Dec 9, 2025
Open
@marielejeune marielejeune force-pushed the 18.0-fix_contract_brand_analytic_distribution-mle branch from a3e4d1a to c218e67 Compare December 18, 2025 09:28
@marielejeune
Copy link
Copy Markdown
Contributor Author

marielejeune commented Dec 18, 2025

Removed the test-requirements as related PRs are merged.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 19, 2026
@marielejeune marielejeune force-pushed the 18.0-fix_contract_brand_analytic_distribution-mle branch from c218e67 to 17110cb Compare April 20, 2026 06:41
@marielejeune
Copy link
Copy Markdown
Contributor Author

marielejeune commented Apr 20, 2026

Rebased on 18.0

@sbejaoui
Copy link
Copy Markdown
Contributor

sbejaoui commented Apr 20, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 20, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-284-by-sbejaoui-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 20, 2026
@OCA-git-bot
Merge PR #284 into 18.0
e389e0e 
Signed-off-by sbejaoui
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 20, 2026

@sbejaoui your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-284-by-sbejaoui-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@marielejeune marielejeune force-pushed the 18.0-fix_contract_brand_analytic_distribution-mle branch 2 times, most recently from a7413db to f9d911f Compare April 20, 2026 07:15
@marielejeune
[IMP] contract_brand: Add unit test for the following case:
d697ebd 
Ensure analytic distribution models applied on products & brands are combined
@marielejeune marielejeune force-pushed the 18.0-fix_contract_brand_analytic_distribution-mle branch from f9d911f to d697ebd Compare April 20, 2026 07:28
@marielejeune marielejeune changed the title [18.0] [FIX] contract_brand: fix analytic distribution compute on contract lines [18.0] [IMP] contract_brand: add unit test case Apr 20, 2026
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 26, 2026
BhaveshHeliconia
BhaveshHeliconia approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 15, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

+1 more reviewer

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:contract_brand Module contract_brand ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marielejeune @OCA-git-bot @sbejaoui @BhaveshHeliconia