[18.0][FIX] ai_oca_bridge: honor timeout from _execute_kwargs - #108
Open
marcelsavegnago wants to merge 1 commit into
Open
[18.0][FIX] ai_oca_bridge: honor timeout from _execute_kwargs#108marcelsavegnago wants to merge 1 commit into
marcelsavegnago wants to merge 1 commit into
Conversation
Hardcoding timeout=30 and unpacking _execute_kwargs that may also contain timeout raises TypeError. Downstream modules cannot set a per-bridge HTTP timeout without replicating _execute.
marcelsavegnago
force-pushed
the
18.0-fix-ai_oca_bridge-timeout-kwargs
branch
from
August 28, 2026 05:15
9cd2f0d to
eef19b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of the
timeoutparameter in theai_bridge_executionmodel and adds a corresponding test to ensure correct behavior. The main focus is to allow thetimeoutvalue to be overridden via keyword arguments, enhancing flexibility and preventing potential errors.Enhancements to timeout handling:
_executemethod inai_bridge_execution.pyto extract thetimeoutvalue from keyword arguments, defaulting to 30 seconds if not provided, and ensuring it is passed correctly to therequests.postcall.Testing improvements:
test_execute_timeout_from_kwargsintest_bridge.pyto verify that thetimeoutparameter can be set via keyword arguments and defaults to 30 when not specified. The test also checks that noTypeErroris raised and that the execution state is correctly set to"done".