[18.0][ADD] account_analytic_maintenance_stock: Propagate analytic distribution to maintenance stock moves

[Ricardo-MC]

When stock moves are linked to maintenance equipment through the
maintenance_stock module, this module propagates the analytic
distribution configured on the equipment to the stock move.

The implementation is intentionally limited to stock moves related to
maintenance equipment and only fills the analytic distribution when it
has not already been set, preserving values provided by other modules.

Currently maintenance_stock does not provide a dedicated hook to
initialize stock move values, so this module overrides create() with a
narrowly scoped implementation.

[celm1990]

LGTM, but couldn't this be assigned before the record is created?

This would avoid triggering a write immediately after create and optimize the flow.

For example, you could retrieve the default_maintenance_request_id from the context in default_get or use a similar approach.

[celm1990]

Please add some tests as well.

[celm1990]

Depends on

• [18.0][ADD] account_analytic_maintenance: Add analytic distribution on maintenance equipment #948

[celm1990]

@Ricardo-MC, please review my comments. I think this is a better approach, and the user will see the analytic distribution immediately instead of only after saving the record.

[celm1990]

I think you should use the context from the action action_view_stock_picking_ids: https://github.com/OCA/maintenance/blob/33ae57cec76a3884a01e9567ef3c8d7386022cff/maintenance_stock/models/maintenance_request.py#L25

Suggested change

	picking_form = Form(
	self.env["stock.picking"].with_context(
	default_maintenance_request_id=self.request.id,
	)
	)
	picking_form.picking_type_id = self.maintenance_warehouse.cons_type_id
	action = self.request.action_view_stock_picking_ids()
	picking_form = Form(
	self.env["stock.picking"].with_context(**action["context"])
	)

[Ricardo-MC]

@celm1990
Fixed, Thanks!