Skip to content

[18.0][MIG] sale_stock_analytic: Migration to 18.0 - #818

Open
jdidderen wants to merge 12 commits into
OCA:18.0from
jdidderen:18.0-mig-sale_stock_analytic
Open

[18.0][MIG] sale_stock_analytic: Migration to 18.0#818
jdidderen wants to merge 12 commits into
OCA:18.0from
jdidderen:18.0-mig-sale_stock_analytic

Conversation

@jdidderen

@jdidderen jdidderen commented Aug 16, 2025

Copy link
Copy Markdown

Based on #617

luisDIXMIT
luisDIXMIT approved these changes Aug 29, 2025
View reviewed changes

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and LGTM!

@github-actions

github-actions Bot commented Dec 28, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 28, 2025
@Saran440

Saran440 commented Jan 21, 2026

Copy link
Copy Markdown
Member

@jdidderen Can you update code again please?

Functional Test 👍

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
baimont and others added 11 commits February 15, 2026 18:34
@baimont @jdidderen
[13.0][ADD] new module sale_stock_analytic
7ff5a9d
@rousseldenis @jdidderen
[14.0][MIG] sale_stock_analytic
0acc832
@rousseldenis @jdidderen
[IMP] sale_stock_analytic: Depends on sale_stock
128716b
@rousseldenis @jdidderen
[IMP] sale_stock_analytic: Improve tests
abc5caa
@oca-travis @jdidderen
[UPD] Update sale_stock_analytic.pot
cf3c337
@mymage @jdidderen
Added translation using Weblate (Italian)
bc29252
@mymage @jdidderen
Translated using Weblate (Italian)
8fdb656 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-analytic-14.0/account-analytic-14.0-sale_stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-sale_stock_analytic/it/
@moitabenfdz @jdidderen
[MIG] sale_stock_analytic: Migration to 15.0
7805c5a
@moitabenfdz @jdidderen
[MIG] sale_stock_analytic: Migration to 16.0
6d8417d
@moitabenfdz @jdidderen
[IMP] sale_stock_analytic: pre-commit stuff
4818ec6
@moitabenfdz @jdidderen
[MIG] sale_stock_analytic: Migration to 17.0
b961c6b
@jdidderen
jdidderen force-pushed the 18.0-mig-sale_stock_analytic branch from 0c420ed to 8bc5700 Compare February 15, 2026 17:34
@jdidderen

jdidderen commented Feb 15, 2026

Copy link
Copy Markdown
Author

@jdidderen Can you update code again please?

Functional Test 👍

It's rebased

rjaraspearhead
rjaraspearhead suggested changes May 28, 2026
View reviewed changes

@rjaraspearhead rjaraspearhead left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, it looks good to me. The only change I would suggest is using BaseCommon to optimize the tests.

Comment thread sale_stock_analytic/tests/test_sale_stock_analytic.py Outdated
Comment thread sale_stock_analytic/tests/test_sale_stock_analytic.py Outdated
@jdidderen
jdidderen force-pushed the 18.0-mig-sale_stock_analytic branch from 8bc5700 to 37ca642 Compare May 31, 2026 06:54
@OCA-git-bot OCA-git-bot added series:18.0 mod:sale_stock_analytic Module sale_stock_analytic labels May 31, 2026
@jdidderen

jdidderen commented May 31, 2026

Copy link
Copy Markdown
Author

Thanks for your help, it looks good to me. The only change I would suggest is using BaseCommon to optimize the tests.

I made the requested changes. Thanks for the review 👍

BhaveshHeliconia
BhaveshHeliconia suggested changes Jun 3, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to create a res.partner record when using BaseCommon, as it is already provided by the base class.

Comment thread sale_stock_analytic/tests/test_sale_stock_analytic.py Outdated
@jdidderen
jdidderen force-pushed the 18.0-mig-sale_stock_analytic branch from 37ca642 to e5a9f90 Compare June 28, 2026 11:49
@jdidderen

jdidderen commented Jun 28, 2026

Copy link
Copy Markdown
Author

No need to create a res.partner record when using BaseCommon, as it is already provided by the base class.

Thanks for the review. I have updated the code 🙏

@CILC98

CILC98 commented Jul 10, 2026

Copy link
Copy Markdown

@BhaveshHeliconia Hi! Your help reviewing this module, please.

BhaveshHeliconia
BhaveshHeliconia approved these changes Jul 13, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

rjaraspearhead
rjaraspearhead approved these changes Jul 20, 2026
View reviewed changes
Comment thread sale_stock_analytic/tests/test_sale_stock_analytic.py
Comment on lines +30 to +32
"analytic_distribution": dict(
{str(cls.env.ref("analytic.analytic_agrolait").id): 100.0}
),

@rjaraspearhead rjaraspearhead May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"analytic_distribution": dict(
{str(cls.env.ref("analytic.analytic_agrolait").id): 100.0}
),
"analytic_distribution": {cls.env.ref("analytic.analytic_agrolait").id: 100.0},

@rjaraspearhead rjaraspearhead May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify this? It’s a bit easier to understand this way.

@rjaraspearhead rjaraspearhead Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @jdidderen

@JanGebelSAMSA-IT

JanGebelSAMSA-IT commented Aug 20, 2026

Copy link
Copy Markdown

@jdidderen Took a look at your migration and I have 2 suggestions for you.

  1. Update the manifest summary. In Odoo 18 analytic tags are not used anymore as far as I know.
  2. Is there a specific reason to keep extending analytic_distribution via _get_stock_move_values() of stock.rule instead of using _prepare_procurement_values() on sale.order.line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@Saran440 Saran440 Saran440 approved these changes
@luisDIXMIT luisDIXMIT luisDIXMIT approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
@rjaraspearhead rjaraspearhead rjaraspearhead approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:sale_stock_analytic Module sale_stock_analytic series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.