[16.0][MIG]sale_stock_analytic - #616
Closed
moitabenfdz wants to merge 7 commits into
Closed
Conversation
cvinh
suggested changes
Feb 9, 2024
| sol_id = move_values.get("sale_line_id", False) | ||
| if sol_id: | ||
| sol_model = self.env["sale.order.line"] | ||
| sol = sol_model.browse(sol_id) |
Contributor
There was a problem hiding this comment.
We should consider the case where the analytic account is at the sale order level. In that case, we have to take the sale order analytic account on every line of the stock move
Contributor
There was a problem hiding this comment.
I don't think we have to do this. Passing analytic_distribution to stock move is enough.
sergiobstoj
reviewed
Aug 9, 2024
| cls.sale_order_line_model = cls.env["sale.order.line"] | ||
| cls.product_model = cls.env["product.product"] | ||
| cls.res_partner_model = cls.env["res.partner"] | ||
|
|
Member
There was a problem hiding this comment.
Try to avoid whitespaces in-between methods
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.