fix(tabufline): implement show_numbers option to display buffer index#550
Open
papier-krieger wants to merge 1 commit into
Open
fix(tabufline): implement show_numbers option to display buffer index#550papier-krieger wants to merge 1 commit into
papier-krieger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
show_numbersoption is documented innvchad_types/chadrc.luaand appearsin the tabufline config, but was never implemented. When set to
true, no numbersare displayed on the buffer tabs.
Additionally, the number shown was the internal Neovim
bufnr(e.g. 6, 12, 24)instead of the sequential buffer index (1, 2, 3...).
Solution
In
style_buf(nr, i, w), the parameterialready receives the correct sequentialindex from
modules.lua, but was never used. This fix readsopts.show_numbersandprepends the index
ito the buffer tab label when enabled.Changes
lua/nvchad/tabufline/utils.lua: use parameterito display buffer index whenshow_numbers = true