Sourcery refactored master branch#1
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| """ | ||
| @classmethod | ||
| def debug(*args, **kwargs): | ||
| def debug(cls, **kwargs): |
Author
There was a problem hiding this comment.
Function LOG.debug refactored with the following changes:
- The first argument to class methods should be
cls(class-method-first-arg-name)
|
|
||
| @classmethod | ||
| def info(*args, **kwargs): | ||
| def info(cls, **kwargs): |
Author
There was a problem hiding this comment.
Function LOG.info refactored with the following changes:
- The first argument to class methods should be
cls(class-method-first-arg-name)
|
|
||
| @classmethod | ||
| def warning(*args, **kwargs): | ||
| def warning(cls, **kwargs): |
Author
There was a problem hiding this comment.
Function LOG.warning refactored with the following changes:
- The first argument to class methods should be
cls(class-method-first-arg-name)
|
|
||
| @classmethod | ||
| def error(*args, **kwargs): | ||
| def error(cls, **kwargs): |
Author
There was a problem hiding this comment.
Function LOG.error refactored with the following changes:
- The first argument to class methods should be
cls(class-method-first-arg-name)
|
|
||
| @classmethod | ||
| def critical(*args, **kwargs): | ||
| def critical(cls, **kwargs): |
Author
There was a problem hiding this comment.
Function LOG.critical refactored with the following changes:
- The first argument to class methods should be
cls(class-method-first-arg-name)
| """ | ||
| sector = self.current_sector_data | ||
| for dummy in range(8): | ||
| for _ in range(8): |
Author
There was a problem hiding this comment.
Function Disk._harvest_entries refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore) - Replace boolean ternary with inline if expression (
ternary-to-if-expression) - Replace if statement with if expression (
assign-if-exp)
| return self._show_error() | ||
|
|
||
| return 0 | ||
| return self._show_error() if not self._call_command('delete', dst=dst) else 0 |
Author
There was a problem hiding this comment.
Function Uc1541.rm refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-554
to
+551
| perms = "-r%s-r--r--" % (rw.strip() and "-" or "w") | ||
| perms = f'-r{rw.strip() and "-" or "w"}-r--r--' |
Author
There was a problem hiding this comment.
Function Uc1541._get_dir refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-569
to
+566
| if self._verbose: | ||
| return self.err | ||
| else: | ||
| return 1 | ||
| return self.err if self._verbose else 1 |
Author
There was a problem hiding this comment.
Function Uc1541._show_error refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-582
to
+583
| command = ['c1541', '-attach', self.arch, '-%s' % cmd] | ||
| command = ['c1541', '-attach', self.arch, f'-{cmd}'] | ||
| if src: | ||
| command.append(src) | ||
| if dst: | ||
| command.append(dst) | ||
|
|
||
| LOG.debug('executing command: %s', ' '.join(command)) | ||
| # For some reason using write and delete commands and reading output | ||
| # confuses Python3 beneath MC and as a consequence MC report an | ||
| # error...therefore for those commands let's not use | ||
| # universal_newlines... | ||
| universal_newlines = True | ||
| if cmd in ['delete', 'write']: | ||
| universal_newlines = False | ||
| universal_newlines = cmd not in ['delete', 'write'] |
Author
There was a problem hiding this comment.
Function Uc1541._call_command refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Move setting of default value for variable into
elsebranch (introduce-default-else) - Simplify boolean if expression (
boolean-if-exp-identity) - Replace if statement with if expression (
assign-if-exp) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
This removes the following comments ( why? ):
# universal_newlines...
# error...therefore for those commands let's not use
# confuses Python3 beneath MC and as a consequence MC report an
# For some reason using write and delete commands and reading output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!