LLT-7587: natlab: wait for starting containers before releasing control - #1968
Merged
Conversation
gytsto
changed the title
tomaszklak
reviewed
Aug 26, 2026
gytsto
force-pushed
the
natlab-wait-starting-containers
branch
from
August 26, 2026 12:14
e88f1f1 to
0f528d5
Compare
gytsto
force-pushed
the
natlab-wait-starting-containers
branch
from
August 26, 2026 12:20
0f528d5 to
e88f1f1
Compare
When a container crashes during 'compose up --wait', compose aborts the whole wait early and manage_containers() only restarted missing/unhealthy services, letting tests start while slow-boot VMs were still in the 'starting' health state. Setup checks then hit a half-booted VM and failed the session.
gytsto
force-pushed
the
natlab-wait-starting-containers
branch
from
August 26, 2026 12:31
e88f1f1 to
38e3aa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A container crashing during
compose up --waitaborts the whole wait early.manage_containers()recovery only restarted missing/unhealthy services and treated healthstartingas fine, so tests started while slow-boot VMs were still booting. Setup checks then hit a half-booted VM (SSH connection refused) and killed the session (libtelio-build job 38345856 on v6.1.4: openwrt-gw-03 crashed once, Windows VM got ~2.5 min instead of ~10).Solution
manage_containers()now also tracksstartingservices and polls until they resolve to healthy/unhealthy, with a 1200s backstop (every healthcheck resolvesstartingwithin ~300s by config).startingflipping to unhealthy still goes through the existing restart path.☑️ Definition of Done checklist