Fix duration failsafe clamping durationEnter twice instead of durationExit - #93
Open
ericlewis wants to merge 1 commit into
Open
Fix duration failsafe clamping durationEnter twice instead of durationExit#93ericlewis wants to merge 1 commit into
ericlewis wants to merge 1 commit into
Conversation
…nExit. The single-frame duration failsafe added in 7225537 tested durationExit but assigned the clamped value to durationEnter, leaving durationExit unclamped. Found while triaging upstream issue NobleRobot#87. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for cheery-choux-736619 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-frame duration failsafe added in 7225537 tests
durationExitbut assigns the clamped value todurationEnter:So a too-short
durationExitis left unclamped, and a validdurationEntergets overwritten. One-word fix: assign toself.durationExit.Noticed while looking into #87 (not necessarily the root cause of that crash, but worth fixing either way).
🤖 Generated with Claude Code