Closed
Conversation
51e7863 to
dfa57fd
Compare
Contributor
Author
|
Changelog from 4aae8545d2aa651461708e2e702ac5a9831e43f0 to faab013b3ec3e4de810995a82066afbbab91a2f6:
Changelog from faab013b3ec3e4de810995a82066afbbab91a2f6 to 51e7863ebab0893253559e55f49235cd1300565f:
Changelog from 51e7863ebab0893253559e55f49235cd1300565f to dfa57fdde5deb1bc59a350d0cb3a2eda75af2179:
|
dfa57fd to
2b0bb70
Compare
FliegendeWurst
requested changes
Dec 6, 2024
Comment on lines
+76
to
+77
| dotnet-sdk = dotnetCorePackages.sdk_6_0; | ||
| dotnet-runtime = dotnetCorePackages.runtime_6_0; |
Contributor
Author
|
Welp, I should not have neglected this PR so much. Sorry. 86Box 5.0 comes with a builtin VM manager, and while I'm not sure that makes 86BoxManagerX fully obsolete by any means, it does somewhat obviate the need for this, and therefore I would prefer to not add the maintenance burden of adding another external manager to Nixpkgs. If anyone still wants to pick this up, please feel free to take over where I left off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/RetBox/86BoxManagerX
86BoxManagerX is a cross-platform fork of 86BoxManager, a configuration manager for 86Box. 86BoxManagerX makes it easy to manage multiple different machine configurations using 86Box.
In order to integrate it well into Nixpkgs, the following patches were made:
$XDG_CONFIG_HOMErather than the directory of the assembly, which would point into the read-only Nix store. This is adapted from a pending pull request.The justification for this is a result of the way 86BoxManagerX works: at first startup, it creates the configuration files after detecting the path to 86Box, and encodes the path to 86Box into the configuration file. After this, it does not try to find the 86Box executable again, even if it stops existing. It would be nice if the configuration could override the hardcoded path, but that'd be a much more involved patch, whereas this one is almost entirely just removing things, which should be easy to deal with. Adding upstream support for the hardcoded path might make this easier in the future.
P.S.: The reason the
versionstring differs from the tag in having an additional hyphen is becausebuildDotnetModuledisallows the string1.7.6.0e.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.