nix-format: support remote buffers - #206
Closed
jkxyz wants to merge 1 commit into
Closed
Conversation
Two changes need to be made to support Tramp remote buffers:
1. Pass the second REMOTE arg to `executable-find` to find the
executable on the remote host
2. Avoid using `call-process-region`, which doesn't have a Tramp
equivalent
This change replaces `call-process-region` with `process-file` which
supports executing via Tramp. This function requires writing the
buffer contents to a temporary file first.
Although writing the buffer to a file may have perfomance implications
vs. writing from memory to stdin, they are likely to be
negligibile. Furthermore, this approach is similar to other formatting
libraries like prettier.el:
https://github.com/jscheid/prettier.el/blob/master/prettier.el#L1494
I've also found it to be more reliable than `process-send-string`.
Member
|
I merged a conflicting change in #211. I suspect the reformatter based version is probably compatible with Tramp? |
Contributor
|
It seems it doesn't (purcell/emacs-reformatter#32), but adding support in reformatter benefits more packages. |
Author
|
Yes I'd say that upstream is the place to fix and would benefit other packages too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes need to be made to support Tramp remote buffers:
Pass the second REMOTE arg to
executable-findto find the executable on the remote hostAvoid using
call-process-region, which doesn't have a Tramp equivalentThis change replaces
call-process-regionwithprocess-filewhich supports executing via Tramp. This function requires writing the buffer contents to a temporary file first.Although writing the buffer to a file may have perfomance implications vs. writing from memory to stdin, they are likely to be negligibile. Furthermore, this approach is similar to other formatting libraries like prettier.el:
https://github.com/jscheid/prettier.el/blob/master/prettier.el#L1494
I've also found it to be more reliable than
process-send-string.