companions: the PR #68 repairs, applied against the ratified 4.2 edition - #84
Merged
Nicholas-Keystate merged 1 commit intoAug 27, 2026
Conversation
…ratified 4.2 edition PR Nicholas-Keystate#68 merged unrepaired on 2026-08-14 — the merged blob is byte-identical to the branch tip, so every defect the review raised is live in main. This applies them. Two of the three MAJORs stand; the third did not survive the merge as a defect. PR68-3 (stale-base README regression) never landed — the merge added rows without removing siblings, and the notation register paragraph is intact. PR68-1, stale edition. The closing section named Custos 4.1 and "six commitments"; the ratified edition is 4.2 and §16 enumerates seven, with keyword force over companions. Retargeted, and the README status cell with it. PR68-2, byte-identity overclaim. "Two evaluations of the same triple return byte-identical findings" is what §17's conformance predicate expressly declines today. Restated in the two-grade form the spec uses: semantic full-payload equality now, byte identity by construction once a carriage encoding ratifies. The line 217 claim about the same defeat down to the byte is untouched — that one rides the canonical-selection SHALL and was never in dispute. PR68-6, the table split. The companion row sat behind a blank line and rendered outside the table. Also corrects the header count, which read "four" against six rows before this companion arrived and seven after. Minors: the terminality sketch omitted the one permitted exit from affirmed/defeated; the self-convicted gloss omitted the key-tier caveat that a lawfully superseding event reconciles rather than convicts, which is the first question a Kever-holding reader asks; the GLEIF adopted-grade claim now points at the companion that grounds it. On the register, "the price is sovereignty" was the one hit the 2026-08-10 amendment left live, and the sentence no longer frames the tradeoff as a purchase. No ratified bytes touched. verify_kernel.py 7/7. Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the repairs from the review on #68. No ratified bytes are touched;
verify_kernel.pyis 7/7.Why this is a separate PR
#68 merged on 2026-08-14 without the repairs. The merged blob is byte-identical to the branch tip
76f068e—git diff 76f068e:companions/custos-for-keri-practitioners.md main:...is empty — so every defect the review raised on 2026-08-10 has been live inmainsince. This is that repair, arriving late.One correction to the review's own tally, in its favor. PR68-3 (stale-base README regression) never happened. The merge diff on
companions/README.mdadds two lines and removes none: all six sibling rows and the owed notation-register paragraph survive. Either the branch was rebased before merge or GitHub resolved it cleanly. Nothing to repair there.The two live MAJORs
PR68-1, stale edition. The closing section read "The most instructive section of Custos 4.1… Six commitments are fixed." The ratified edition is 4.2, and §16 enumerates seven (
spec/custos-4.2.md:2886, "Seven commitments bound the governance evaluator"), in this edition's own text and with keyword force over companions. Retargeted the section and the README status cell to 4.2.PR68-2, byte-identity overclaim. Line 165 read "Two evaluations of the same triple return byte-identical findings." The ratified text expressly declines this today at
spec/custos-4.2.md:1632: findings SHALL be equal "under the one conformance predicate of section 17: semantic full-payload equality today, byte identity by construction the moment a carriage encoding ratifies." Restated in that two-grade form. This is the sentence the whole chess-scoresheet argument lands on, so it carries the qualification rather than dropping the claim.The review was right that line 217 ("the same defeat down to the byte") is a different claim and is sound — it rides the canonical-selection SHALL at
spec/custos-4.2.md:1769. Untouched.PR68-6, and a count defect the review didn't catch
The companion's README row sat behind a blank line, which severed it from the table above; it rendered as its own stray one-row table. Blank line removed.
While there:
companions/README.md:3read "Four companions travel beside the ratified kernel" and line 7 "Two of the four". That was already wrong before #68 — the table held six rows — and #68 made it seven. Both counts corrected. Flagging it as pre-existing rather than folding it in silently.Minors
spec/custos-4.2.md:1712states the one event that is an exception: a contradictory pair bearing on the same question moves either to self-convicted. One sentence added, since this audience implements from that sketch.spec/custos-4.2.md:1531: at the key tier, whether a pair bears is decided by KERI's own superseding-recovery rules, and a lawfully superseding event reconciles rather than convicts. This is the first question a Kever-holding reader asks, so it belongs in the gloss.Not done
PR68-9 and the analogy leak are not addressed. PR68-9 was a NOTE on simplifying the lexicographic sentence, and the review's closing observation was that the chess figure never confesses its second boundary — chess assumes a single, integral, complete scoresheet, with no duplicity and no completeness surface. Both are judgment calls about the author's own figure, and I'd rather not make them on his behalf in a repair PR. They're worth a follow-up.
The review report the comment cites is not in the repo.
reviews/rounds/pr68-companion-review-2026-08-10/review.mddoesn't exist onmain. The findings survive in the PR comment on #68, but the report itself was never committed, so the evidence set has a hole where the other rounds have records.Relates to #68.