Skip to content

fix: Missing extension byte on non-English Windows. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyq0918dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Missing extension byte on non-English Windows. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/src/process.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,15 @@ Future<ProcessResult> runProcess({
runInShell: Platform.isWindows && workingDirectory != null,
);

// Windows uses system encoding (e.g., GBK for Chinese), while
// Linux/macOS use UTF-8 for process output.
final encoding = Platform.isWindows ? systemEncoding : utf8;
final stdoutFuture = process.stdout
.transform(utf8.decoder)
.transform(encoding.decoder)
.transform(const LineSplitter())
.forEach(stdout.writeln);
final stderrFuture = process.stderr
.transform(utf8.decoder)
.transform(encoding.decoder)
.transform(const LineSplitter())
.forEach(stderr.writeln);
await Future.wait([stdoutFuture, stderrFuture]);
Expand Down