Develop#218
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Express app-level CORS handling and Swagger/OpenAPI spec serving in app.js to tighten browser access controls and expose the raw API specification.
Changes:
- Replaces the permissive CORS origin handling with environment-specific allowed origins.
- Adds CORS preflight caching via
maxAge. - Adds
/swagger.jsonfor serving the loaded OpenAPI document and adjusts Swagger UI options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return callback(null, true); | ||
| if (!origin) return callback(null, true); // server-to-server, curl, R package | ||
| if (allowedOrigins.includes(origin)) return callback(null, true); | ||
| return callback(new Error(`CORS: origin ${origin} not allowed`)); |
Comment on lines
+41
to
+43
| const allowedOrigins = env === 'production' | ||
| ? ['https://data.neotomadb.org'] | ||
| : ['http://localhost:5173', 'http://127.0.0.1:5173']; |
Comment on lines
+104
to
+105
| // Serve the raw spec at /swagger.json so Swagger UI can find it | ||
| // (it falls back to this URL when the inline embed doesn't catch). |
Comment on lines
+104
to
+106
| // Serve the raw spec at /swagger.json so Swagger UI can find it | ||
| // (it falls back to this URL when the inline embed doesn't catch). | ||
| app.get('/swagger.json', (req, res) => res.json(swaggerDocument)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates CORS handling and Swagger documentation serving in
app.jsfor improved security and compatibility. The main changes are:CORS Policy Improvements:
allowedOriginsarray based on the environment, now strictly blocking unrecognized origins instead of allowing them and logging a warning. This tightens security by rejecting requests from origins not explicitly allowed.maxAgeproperty to the CORS options to cache preflight responses for 600 seconds, reducing unnecessary preflight requests.Swagger Documentation Enhancements:
/swagger.jsonendpoint to serve the raw OpenAPI spec, improving Swagger UI compatibility and enabling external tools to access the API spec directly.swaggerUrloption in Swagger UI setup, relying on the new/swagger.jsonendpoint instead.