feat(RoleController): add RoleController - #9
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new RoleController and exposes read-only role endpoints via routes/api.php, while also adjusting the existing user routes to use a pluralized base path.
Changes:
- Add
RoleControllerwithindex(paginated list) andshow(single role) responses. - Add
/rolesand/roles/{role}API routes. - Rename user endpoints from
/userto/users, including the restore route.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| routes/api.php | Adds role routes and pluralizes user routes (user → users). |
| app/Http/Controllers/RoleController.php | Implements role listing and retrieval endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Route::apiResource('users', UserController::class)->missing(function (Request $request) { | ||
| return response()->json([ | ||
| 'message' => 'Usuario no encontrado', | ||
| ], 404); | ||
| }); | ||
| Route::patch('user/{id}/restore', [UserController::class, 'restore']); | ||
| Route::patch('users/{id}/restore', [UserController::class, 'restore']); |
There was a problem hiding this comment.
Esta PR cambia los endpoints de usuarios de /user a /users (y también el restore), lo cual es un cambio breaking para cualquier cliente que ya consuma la API. Si es intencional, actualiza el título/descrpción de la PR y considera mantener temporalmente las rutas antiguas como alias/deprecadas (o versionar la API) para evitar romper integraciones existentes.
| Route::get('roles', [RoleController::class, 'index']); | ||
| Route::get('roles/{role}', [RoleController::class, 'show']); No newline at end of file |
There was a problem hiding this comment.
Para consistencia y menor duplicación, considera declarar las rutas de roles como apiResource (p. ej. limitado a index/show) en lugar de dos Route::get manuales; así mantienes el patrón usado para users y unificas parámetros/nombres de rutas.
| Route::get('roles', [RoleController::class, 'index']); | |
| Route::get('roles/{role}', [RoleController::class, 'show']); | |
| Route::apiResource('roles', RoleController::class)->only(['index', 'show']); |
No description provided.