Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new automated testing workflows, improves test philosophy documentation, and adds robust test coverage for key services. It also strengthens security and reliability in token generation and test execution. The most important changes are grouped below:
CI/CD Automation and Coverage
.github/workflows/ci.ymlto run tests and collect coverage for all major services and workers (Go, C#, F#, Gleam), ensuring every component is validated on push and pull request.Testing Philosophy and Documentation
docs/guide/testing.mdto clarify the purpose of tests, discourage trivial tests, and provide guidelines for writing effective, bug-catching tests.Service-Specific Test Coverage
src/services/files/internal/service/content_type_test.go, including security checks against dangerous mismatches and normalization logic.src/services/events/internal/handler/publish_test.go, covering valid/invalid formats and edge cases.Security and Permissions
servicePermissionsinsrc/services/auth/internal/handler/token_handler.goand updated service token generation to embed permissions for specific service accounts, improving authorization granularity. [1] [2]Test Runner Reliability
src/services/testing/src/testing/runner.pyto include delays between test categories, preventing gateway rate limiting and ensuring reliable test execution. [1] [2]