fix(theme): restrict AMOLED overrides to dark theme#2
Open
sohan-f wants to merge 1 commit into
Open
Conversation
Prevent AMOLED color replacements from being applied when the app is using a light theme, avoiding unreadable black text on black backgrounds after theme switches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent AMOLED color replacements from being applied when the app is using a light theme, avoiding unreadable black text on black backgrounds after theme switches.
Problem:
When switching from dark theme to light theme, the AMOLED override continues to apply. This results in black backgrounds and black text, making UI elements (such as keys) unreadable unless the theme is switched back to dark mode.
The AMOLED color override logic was being applied without fully respecting the current UI night mode state, causing previously cached or applied overrides to persist across theme transitions.
Fix:
Restrict AMOLED color overrides to dark mode only by checking the current
uiModebefore applying any color replacements.Now overrides are only applied when:
UI_MODE_NIGHT_YES)