Skip to content

Add optional queueId to BLE command queue#261

Merged
fotiDim merged 9 commits into
mainfrom
add-optional-queueId-to-BLE-command-queue
Jun 23, 2026
Merged

Add optional queueId to BLE command queue#261
fotiDim merged 9 commits into
mainfrom
add-optional-queueId-to-BLE-command-queue

Conversation

@rohitsangwan01

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an optional queueId parameter to the BLE command queue, allowing commands to be routed to specific queues. It updates various BLE operations and extensions to accept and propagate this parameter, and adds comprehensive unit tests for the command queue functionality. The feedback suggests improving readability by placing positional arguments before named arguments, using pumpEventQueue() consistently in tests, and ensuring queueId is propagated in the fallback pairing logic when hasSystemPairingApi is false.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/src/universal_ble.dart
Comment thread lib/src/universal_ble.dart
Comment thread test/ble_command_queue_test.dart Outdated
Comment thread test/ble_command_queue_test.dart Outdated
Comment thread lib/src/universal_ble.dart
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@fotiDim fotiDim merged commit c70cdf3 into main Jun 23, 2026
2 checks passed
@fotiDim fotiDim deleted the add-optional-queueId-to-BLE-command-queue branch June 23, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants