Skip to content

[BUGFIX] set_operation_model ordering with layout#867

Merged
misi9170 merged 3 commits into
NatLabRockies:v4from
misi9170:bugfix/set_operation_model-2
Apr 5, 2024
Merged

[BUGFIX] set_operation_model ordering with layout#867
misi9170 merged 3 commits into
NatLabRockies:v4from
misi9170:bugfix/set_operation_model-2

Conversation

@misi9170

@misi9170 misi9170 commented Apr 4, 2024

Copy link
Copy Markdown
Collaborator

In #856 , which fixed a bug that hardcoded a single turbine, I introduced a new bug that meant that if set_operation_model is called before changing the layout, and error was raised because the set_operation_model call broadcast the turbine type to the number of currently available turbines.

This PR addresses this issue by:

  • allowing set_operation_model before changing the layout IF there is only a single turbine type currently AND only a single operation_model is passed to set
  • providing a more informative warning if there is an inconsistency between the number of turbine types and the layout that could have been caused by setting the operation model (or setting multiple operation models)
  • testing these capabilities.

@misi9170 misi9170 added bug Something isn't working v4 Focus of FLORIS v4 labels Apr 4, 2024
@misi9170 misi9170 requested review from paulf81 and rafmudaf April 4, 2024 21:50
@misi9170 misi9170 self-assigned this Apr 4, 2024
@misi9170 misi9170 changed the base branch from main to v4 April 4, 2024 21:51
@misi9170 misi9170 merged commit 99161f2 into NatLabRockies:v4 Apr 5, 2024
@misi9170 misi9170 deleted the bugfix/set_operation_model-2 branch April 5, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v4 Focus of FLORIS v4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants