Add utilities for floris models#839
Closed
paulf81 wants to merge 40 commits into
Closed
Conversation
# Conflicts: # floris/core/core.py
# Conflicts: # examples/01_opening_floris_computing_power.py # examples/02_visualizations.py # examples/03_making_adjustments.py # examples/04_sweep_wind_directions.py # examples/32_plot_velocity_deficit_profiles.py # floris/floris_model.py # floris/flow_visualization.py # floris/layout_functions.py # floris/layout_visualization.py # floris/tools/__init__.py # floris/tools/visualization.py # floris/uncertainty_interface.py # floris/visualization.py # tests/floris_model_integration_test.py
# Conflicts: # floris/floris_model.py # floris/flow_visualization.py
# Conflicts: # floris/floris_model.py # floris/flow_visualization.py # tests/floris_model_integration_test.py
Collaborator
|
I'm going to wait to review until #830 is in to simplify the comparison? |
Collaborator
Author
Collaborator
|
@paulf81 I think v4 branch needs to be merged into this one. |
Collaborator
Author
That's it, somehow I'm not managing to merge in v4, I keep hitting errors. But since this PR is just adding two new files I just quit and started a new pull request off of a more current v4 to avoid the problems. Closing this one in favor of #840 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add utilities for floris models
(Note this will be easier to read when API changes merged to v4)
Previously, we added to flasc a set of utilities to make convenient the changing of FLORIS parameters within the nested dictionary structure. This pull request moves them to FLORIS as they could have uses beyond SCADA comparisons, matching the pattern we set up in PR #805
Originally I had planned to add these to utilities.py, but this creates a circular import since several of the functions accept and return a FlorisModel. So created the files:
floris_model_utils.py
floris_model_utils_test.py
Created tests to confirm correct behaviors. Last item could be if we wanted to provide a convenience function that sets certain parameters without their parents in the case they appear only once in the dictionary. But this a little bit violates the spirit of explicitness seen elsewhere.
A function to print the dictionary in a nice, indented way is provided.