Jf/set initial param levels by juflorez · Pull Request #98 · NatLabRockies/PRAS

juflorez · 2025-11-24T23:14:32Z

Creating initial PR now-will update with graphics/analysis on impact in varying param. Core functionality with backwards compat file reading tests is present though

codecov-commenter · 2025-11-24T23:16:34Z

Codecov Report

❌ Patch coverage is 52.13675% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (fbde94e) to head (3550896).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
PRASFiles.jl/src/Systems/read.jl	45.45%	48 Missing ⚠️
PRASCore.jl/src/Systems/assets.jl	64.70%	6 Missing ⚠️
PRASCore.jl/src/Simulations/Simulations.jl	88.88%	1 Missing ⚠️
PRASFiles.jl/src/Systems/write.jl	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   83.13%   81.30%   -1.84%     
==========================================
  Files          45       45              
  Lines        2325     2407      +82     
==========================================
+ Hits         1933     1957      +24     
- Misses        392      450      +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 23 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sriharisundar · 2026-06-12T23:21:47Z

   transitions from forced outage to operational during a given simulation
   timestep, for each storage unit in each timeperiod. Unitless.

+An optional parameter is available to set the initial state of charge for the unit:


Isn't this a one dimensional array, if so, is it still a dataset, can we qualify it better with info on shape?

sriharisundar · 2026-06-15T20:02:33Z

        initialize_availability!(
            rng, state.lines_available, state.lines_nexttransition,
            system.lines, N)
+        if size(system.storages.energy_capacity, 1) > 0


Is it possible to have one function for these 3 blocks?

sriharisundar · 2026-06-15T20:27:39Z

   operational during a given simulation timestep, for each generator-storage unit in each
   timeperiod. Unitless.
+ - `initial_soc`: Optional keyword for initial state of charge as a fraction [0.0, 1.0] of 
+   `energy_capacity` at the first timestep for each storage unit. Default is zero.


genstor unit*

sriharisundar · 2026-06-15T20:30:44Z

-        λ::Matrix{Float64}, μ::Matrix{Float64},
-        borrowefficiency::Matrix{Float64},paybackefficiency::Matrix{Float64}
+        λ::Matrix{Float64}, μ::Matrix{Float64};
+        initial_borrowed_load::Vector{Float64} = zeros(Float64, length(names)),


Why don't we keep this as the last argument, much like the others?

sriharisundar · 2026-06-15T20:54:09Z

+"""
+Read a SystemModel from a PRAS file in version 0.8.1+ format. Requires initial SOC levels for storages/generator-storages and initial borrowed load/efficiency parameters for demand responses.
+"""
+function systemmodel_0_8_1(f::File)


We're gonna release this with PRASFiles 0.9, so let's call this function.

sriharisundar · 2026-06-15T21:03:13Z

+
+        path = dirname(@__FILE__)
+        version_0_7_0 = SystemModel(path * "/versioned_toy/toymodel_v0_7_0.pras")
+        version_0_8_1 = SystemModel(path * "/versioned_toy/toymodel_v0_8_1.pras")


Again, think this can be 0.9

sriharisundar · 2026-06-15T22:04:19Z

    end

+
+    @testset "Read version 0.7.0 to 0.8.1 compatibility" begin


What are we trying to test for here? To test backward compatibility of our reader, to ensure if we can read 0.7, 0.8 version etc.? The 0.8.1 (or other newer versions) are written from those, original right?

sriharisundar · 2026-06-15T22:27:04Z

+    has_storages = haskey(f, "storages")
+    has_generatorstorages = haskey(f, "generatorstorages")
+
+    if has_storages


Let's pull these blocks into 2 functions read_storages() and read_genstorages(), which take the file handle and the version as a symbol and passes 0 for version <0.9, and passes read-in SoC to the asset struct which is sent back to the calling function. We can then call this in core and can do the same thing as before for 0_5 and 0_8. Same deal with read_demandresponses() except we only check for versions 0_8 and 0_9.

sriharisundar · 2026-06-15T22:29:57Z

+            load_matrix(f["storages/carryoverefficiency"], region_order, Float64),
+            load_matrix(f["storages/failureprobability"], region_order, Float64),
+            load_matrix(f["storages/repairprobability"], region_order, Float64);
+            initial_soc = load_matrix(f["storages/initialsoc"], region_order, Float64)


Why not read with read_vector?

juflorez added 7 commits November 24, 2025 15:41

add initial level setting func

90b4039

update tests

f42e42a

add file reading/writing v1-need to fix versioning

2b4ce69

add versioning structure for soc reading

2ec905b

update tests for prior versioning compat

75728a5

update gitignore for versioned toy test

fe3967b

add docs for new optional soc

fa98b67

juflorez requested review from Copilot, scdhulipala and sriharisundar November 24, 2025 23:14

Copilot started reviewing on behalf of juflorez November 24, 2025 23:18 View session

Copilot finished reviewing on behalf of juflorez November 24, 2025 23:20

Copilot AI reviewed Nov 24, 2025

hsunnrel requested a review from Copilot November 25, 2025 20:22

Copilot started reviewing on behalf of hsunnrel November 25, 2025 20:26 View session

Copilot finished reviewing on behalf of hsunnrel November 25, 2025 20:29

Copilot AI reviewed Nov 25, 2025

View reviewed changes

juflorez added 9 commits November 25, 2025 14:41

fix indexing bug

0f090db

fix file test fpath

de95c67

fix syntax

d690c53

remove confusing comments

6b1aed4

update details in systemmodel hdf5

398f73a

clarify writing method for 0_8_1

75a58b9

fix writing demandresponses bug

413119c

fix writing demandresponses bug follow on

b5c4c9f

fix docstring format

2458a02

juflorez requested a review from Copilot November 25, 2025 22:05

Copilot AI reviewed Nov 25, 2025

Copilot started reviewing on behalf of juflorez November 25, 2025 22:29 View session

Copilot finished reviewing on behalf of juflorez November 25, 2025 22:33

juflorez requested a review from Copilot November 26, 2025 19:17

Copilot AI reviewed Nov 26, 2025

Copilot started reviewing on behalf of juflorez November 26, 2025 19:50 View session

Copilot finished reviewing on behalf of juflorez November 26, 2025 19:55

round initial values to Ints

3550896

juflorez requested a review from Copilot April 30, 2026 17:21

Copilot started reviewing on behalf of juflorez April 30, 2026 17:21 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread PRASFiles.jl/test/runtests.jl

Comment thread docs/src/SystemModel_HDF5_spec.md

Comment thread PRASCore.jl/src/Systems/assets.jl

Comment thread PRASFiles.jl/src/Systems/read.jl

Comment thread PRASFiles.jl/src/Systems/read.jl

Comment thread docs/src/SystemModel_HDF5_spec.md

sriharisundar requested changes Jun 15, 2026

View reviewed changes

		end


		@testset "Read version 0.7.0 to 0.8.1 compatibility" begin

Conversation

juflorez commented Nov 24, 2025

Uh oh!

codecov-commenter commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Nov 24, 2025 •

edited

Loading