Remove config option raise_in_transaction_callbacks - #314
Merged
Conversation
This was referenced Jul 4, 2025
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 4, 2025
bagedevimo
force-pushed
the
graphite-base/314
branch
from
July 4, 2025 22:09
934e630 to
6b528ab
Compare
This is now default in Rails 5.0, so we no longer need this opt-in config option. https://guides.rubyonrails.org/v6.1.0/5_0_release_notes.html#active-record-notable-changes
bagedevimo
force-pushed
the
remove-transaction-callback
branch
from
July 6, 2025 04:24
7881750 to
4deda68
Compare
bagedevimo
marked this pull request as ready for review
July 6, 2025 04:24
Member
|
Just for reference, this was added in #220. |
Holmes98
approved these changes
Jul 6, 2025
Holmes98
left a comment
Holmes98
left a comment
Member
There was a problem hiding this comment.
There's a typo in the commit message (transaction -> transactional), I'll fix that when squash-merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now default in Rails 5.0, so we no longer need this opt-in
config option.
https://guides.rubyonrails.org/v6.1.0/5_0_release_notes.html#active-record-notable-changes