Fix draft navigation reference picker#1142
Open
kernelpanic888 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1084 by taking the simpler "exclude drafts" path from the issue brief.
The navigation relationship picker now keeps the existing tenant scoping and adds
_status = publishedonly when Payload is loadingpagesorpostsoptions.builtInPagesare left with the original tenant-only filter because they do not have draft state.Related Issues
Fixes #1084
Key Changes
getTenantAndPublishedFilterfor polymorphic navigation references.How to test
pnpm run lint-stagedpnpm run tscpnpm testpnpm drift:checkpnpm fallow:audit --ci.husky/check-migrationsScreenshots / Demo video
Not included; this is a relationship picker filtering change with unit coverage.
Migration Explanation
No migration needed.
Future enhancements / Questions
The draft badge approach from the issue would still be a richer UX, but it requires a custom Payload relationship field component. This PR keeps the change small by excluding drafts from the picker.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.