Show City, State at a glance in events viewer#1137
Open
rustynwac wants to merge 1 commit into
Open
Conversation
The public events viewer displayed a venue place name with a caret popover, but City and State were only visible after opening the popover. Add an always-visible "City, State" line beneath the location trigger in LocationPopover so users can scan an event's city and state without clicking. Falls back to city-only or state-only, and is omitted when neither is set. Fixes #1098 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016s7MJjeP8Mr3KRiRA22WwJ
Contributor
|
Preview deployment: https://claudextriage-5ny2nj.preview.avy-fx.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the public events viewer, each event's location was shown as the venue place name with a caret popover. City and State were only visible after opening the popover, so users couldn't tell where an event was happening while scanning the list.
This adds an always-visible
City, Stateline directly beneath the location trigger, matching the layout requested in #1098:Related Issues
Fixes #1098
Key Changes
src/components/EventPreview/LocationPopover.tsx— wrap the popover in a column container and render aCity, Stateline beneath the trigger. Gracefully falls back to city-only or state-only, and is omitted entirely when neither is set. The full address (street, city, state, zip, copy, and "Open in Maps") remains available in the popover.__tests__/client/components/LocationPopover.client.test.tsx— new client tests covering the city+state, city-only, state-only, and neither cases.How to test
/eventspage with events that have a physical location (e.g.nwac.localhost:3000/events).City, Stateline directly beneath it — without clicking the caret.Automated:
pnpm test(529 passing, including the newLocationPopovertests),pnpm tsc,pnpm lint.Screenshots / Demo video
N/A — see "How to test" above.
Migration Explanation
No schema or migration changes; this is a presentational change only.
Future enhancements / Questions
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_016s7MJjeP8Mr3KRiRA22WwJ
Generated by Claude Code