Create a resuable drawer modal#1209
Open
kevinherdez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the drawer component concept from
ImageCaptionFieldEditView.tsxand create a newDrawerModal.tsxthat supports showing a bottom rounded drawer modal that takes a custom child to display anything in the drawer. The two options for the drawer display are only showing on half of the screen or taking up the full screen. I added a spot in the dev menu to test out the functionality, and replaced theEditImageCaptionViewcomponent to use it.The main driver for this is the new UI for the Nokian Tyres sponsorship which is going to use this style of drawer.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.