Implement decorators to register benchmarks add axis and options#347
Open
oleksandr-pavlyk wants to merge 2 commits intoNVIDIA:mainfrom
Open
Implement decorators to register benchmarks add axis and options#347oleksandr-pavlyk wants to merge 2 commits intoNVIDIA:mainfrom
oleksandr-pavlyk wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
cuda.bench.register(fn) continues returning Benchmark, and supports
legacy use.
New signature added:
cuda.bench.register():
Returns a decorator
```
@bench.register()
@bench.axis.float64("Duration (s)", [7e-5, 1e-4, 5e-4])
@bench.option.min_samples(120)
def single_float64_axis(state: bench.State):
...
```
The C++ counterpart's purpose is to demonstrate use of CUPTI metrics, but these are not supported in Python bindings, so this example is a duplicate of example/throughput.py
oleksandr-pavlyk
force-pushed
the
add-decorators
branch
from
6112464 to
6bfd436
Compare
oleksandr-pavlyk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #351
Add decorators for registering a benchmark, adding axis and options.
cuda.bench.register(fn)continues returning Benchmark, and supportslegacy use.
New signature added:
cuda.bench.register()which returns a decorator.This pattern supplements earlier pattern of
This PR adds to #346, and should be merged after it has been merged.Update: The #346 has been merged.