Skip to content

docs: add Windows test commands#889

Open
omribz156 wants to merge 1 commit into
NVIDIA:mainfrom
omribz156:codex/windows-test-docs
Open

docs: add Windows test commands#889
omribz156 wants to merge 1 commit into
NVIDIA:mainfrom
omribz156:codex/windows-test-docs

Conversation

@omribz156

Copy link
Copy Markdown

Summary

  • Add Windows commands for building test binaries with the existing testing/build.bat helper
  • Show the PowerShell form of NUMBA_CUDA_TEST_BIN_DIR
  • Add language hints to the existing README command blocks

Fixes #862.

Verification

  • git diff --check
  • rg -n "build.bat|NUMBA_CUDA_TEST_BIN_DIR|pytest -n auto|pixi run" README.md testing pixi.toml

Full test execution was not run because this is a docs-only change and this local machine is not a CUDA-capable Windows test environment.

This was prepared with Codex assistance and manually reviewed, with the patch kept to the README test-running instructions.

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented May 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@acosmicflamingo

Copy link
Copy Markdown

Copying what I had written in original ticket so maintainers are aware while reviewing the PR:

so that build.bat script was called by ci/test_wheel.ps1 a few months ago in this #683, and it was the only thing referencing build.bat before it was removed from the codebase. Additionally, it doesn't look like it was getting as many updates as Makefile currently does. With that being said, before giving build.bat a well-needed makeover, I think we first need to know whether we are better off maintaining two distinct files, or whether we should leverage unix-tools in Windows so we can just use Makefile

TL;DR: the build.bat script hasn't been maintained for a while, so the PR in its current form isn't enough to address the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Add steps for running tests on Windows

2 participants