nccl_ep: Remove unused tensor type enum#2042
Open
artpol84 wants to merge 1 commit intoNVIDIA:masterfrom
Open
Conversation
Clean the codebase removing the deadcode Signed-off-by: Artem Y. Polyakov <artemp@nvidia.com>
sb17v
reviewed
Mar 11, 2026
| // Tensor containing tokens received per expert (pinned host memory) | ||
| NCCL_EP_TENSOR_TAG_RECV_EXPERT_COUNTER_HOST = 6, | ||
| // Tensor containing per-expert token counts | ||
| NCCL_EP_TENSOR_TAG_TOKENS_PER_EXPERTS = 7, |
Collaborator
There was a problem hiding this comment.
I think we need to fix the following in the dispatch API if we are removing this:
// local_tensors - [IN,OUT] Array of pointers to preallocated tensors, with information that is local to the rank.
// LL mode: accepts 1 optional local tensor:
// NUM_TOKENS_PER_EXPERTS: [OUT] a 1D tensor of unsigned int [num_experts]
// that contains the number of tokens received by each expert on this rank.
Collaborator
Author
There was a problem hiding this comment.
This enum is a deadcode, the two enums above duplicate it and are actually used:
https://github.com/NVIDIA/nccl/pull/2042/changes#diff-0ed431b7dc072f7ce49c9470b66954b5beba57b7fdf066e641d0b9867012fe0eL32
Collaborator
Author
There was a problem hiding this comment.
No API changes required. This PR is a code cleanup only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean the codebase removing the deadcode