fix (dpf/bf4): Remove unsupport parameter HIDE_PORT2_PF from bf4 flavor

[abvarshney-nv]

Remove unsupport parameter HIDE_PORT2_PF from bf4 flavor

Related issues

Type of Change

• Add - New feature or capability
• Change - Changes in existing functionality
• Fix - Bug fixes
• Remove - Removed features or deprecated functionality
• Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

• This PR contains breaking changes

Testing

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• No testing required (docs, internal refactor, etc.)

Additional Notes

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4426fa72-cb40-4f8d-9927-760adad89fa4

📥 Commits

Reviewing files that changed from the base of the PR and between 6a45cc0 and 3a57807.

📒 Files selected for processing (1)

• crates/dpf/src/flavor.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/dpf/src/flavor.rs

---

Summary by CodeRabbit

• Bug Fixes
  • Updated the default BF4 network configuration to use the correct Ethernet link types for port 1 and port 2.
  • Removed an unsupported port-hiding option from the BF4-generated configuration while keeping the default single-function setup (NUM_OF_PF=1).

Walkthrough

BF4 flavor construction now uses a dedicated NVConfig builder. The BF4 parameter set omits the unsupported HIDE_PORT2_PF, retains NUM_OF_PF=1, and sets both link types to ETH; the generic NVConfig remains unchanged.

Changes

BF4 NVConfig defaults

Layer / File(s)	Summary
Configure BF4 NVConfig defaults crates/dpf/src/flavor.rs	BF4 construction uses get_bf4_default_nvconfig(), which documents and omits HIDE_PORT2_PF, retains NUM_OF_PF=1, and sets LINK_TYPE_P1/LINK_TYPE_P2 to ETH.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately identifies the BF4 flavor fix removing the unsupported HIDE_PORT2_PF parameter.
Description check	✅ Passed	The description matches the change and clearly states the BF4 HIDE_PORT2_PF removal fix.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/dpf/src/flavor.rs`:
- Around line 369-371: Update the default_nvconfig_shape test to expect 15
parameters instead of 16, assert that LINK_TYPE_P1=ETH and LINK_TYPE_P2=ETH are
present, and assert that HIDE_PORT2_PF is absent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93146c47-3c8e-4c08-8d41-a8c04339bc63

📥 Commits

Reviewing files that changed from the base of the PR and between eb4ea22 and eb8adc5.

📒 Files selected for processing (1)

• crates/dpf/src/flavor.rs

[github-actions]

🔍 Container Scan Summary

Service	Total	Critical	High	Medium	Low	Other
boot-artifacts-aarch64	3	0	0	3	0	0
boot-artifacts-x86_64	3	0	0	3	0	0
forge-admin-cli-x86_64	259	13	30	78	7	131
machine-validation-runner	807	40	234	288	36	209
machine_validation	807	40	234	288	36	209
machine_validation-aarch64	807	40	234	288	36	209
nvmetal-carbide	807	40	234	288	36	209
TOTAL	3493	173	966	1236	151	967

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.