Skip to content

gen-fields: use explicit legacy field source#127

Merged
nccurry merged 4 commits into
mainfrom
ncurry/legacy-field-source
Jun 22, 2026
Merged

gen-fields: use explicit legacy field source#127
nccurry merged 4 commits into
mainfrom
ncurry/legacy-field-source

Conversation

@nccurry

@nccurry nccurry commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move curated lowercase legacy field names into pkg/dcgm/legacy_fields.csv.
  • Add --legacy-fields support to cmd/gen-fields and wire go:generate to use it.
  • Keep deprecated DCGM_FI_* aliases derived from dcgm_fields.h.

Motivation

This separates curated compatibility names from generated header-derived aliases. The generator no longer has to infer the curated lowercase names from generated output or header/comment patterns; they now live in an explicit source file that can be reviewed directly.

Testing

  • go test ./cmd/gen-fields
  • make check-generate
  • git diff --check

@nccurry nccurry requested a review from rvatkar May 28, 2026 15:16
Signed-off-by: Nick Curry <ncurry@nvidia.com>
@nccurry nccurry force-pushed the ncurry/legacy-field-source branch from e2bd544 to ad55ab1 Compare May 28, 2026 15:24
Comment thread cmd/gen-fields/main.go Outdated
nccurry added 3 commits June 12, 2026 10:49
Signed-off-by: Nick Curry <ncurry@nvidia.com>
Signed-off-by: Nick Curry <ncurry@nvidia.com>
Signed-off-by: Nick Curry <ncurry@nvidia.com>
@nccurry nccurry merged commit 0740c4c into main Jun 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants