[Doca_DPF]update kubernetes version and DPF plugin resource list#110
[Doca_DPF]update kubernetes version and DPF plugin resource list#110souleb wants to merge 1 commit into
Conversation
Signed-off-by: Soule BA <souleb@nvidia.com>
📝 WalkthroughWalkthroughThe PR updates the container runtime build stage to Kubernetes 1.34 with improved system dependency installation reliability through curl retry mechanisms and apt retry policies, and updates the DOCA plugin to discover Kubernetes custom resources using plural API names instead of singular forms. ChangesContainer Runtime and Plugin Configuration Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile (1)
54-57: ⚡ Quick winClarify the need for
--allow-downgrades.The
--allow-downgradesflag permits installing older package versions than currently installed. In a fresh container build this is typically unnecessary and could mask dependency conflicts. Consider removing it unless there's a specific version pinning requirement.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile` around lines 54 - 57, The RUN apt-get install command includes the unnecessary --allow-downgrades flag; remove --allow-downgrades from the RUN apt-get install invocation in the Dockerfile (the line starting "RUN apt-get update ... && apt-get install -y") so the build won't permit downgrades by default; if there is a deliberate need to force specific older package versions instead, instead of leaving the flag, add an explicit comment and pin the package versions in the same RUN command to make the requirement explicit.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Dockerfile`:
- Around line 54-57: The RUN apt-get install command includes the unnecessary
--allow-downgrades flag; remove --allow-downgrades from the RUN apt-get install
invocation in the Dockerfile (the line starting "RUN apt-get update ... &&
apt-get install -y") so the build won't permit downgrades by default; if there
is a deliberate need to force specific older package versions instead, instead
of leaving the flag, add an explicit comment and pin the package versions in the
same RUN command to make the requirement explicit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fc2bda33-fa8f-4019-b9d5-b529f6efc1e3
📒 Files selected for processing (2)
Dockerfilesos/report/plugins/doca_dpf.py
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines
Summary by CodeRabbit
Chores
Bug Fixes