Skip to content

[Doca_DPF]update kubernetes version and DPF plugin resource list#110

Open
souleb wants to merge 1 commit into
NVIDIA:mainfrom
souleb:k8s-1.34
Open

[Doca_DPF]update kubernetes version and DPF plugin resource list#110
souleb wants to merge 1 commit into
NVIDIA:mainfrom
souleb:k8s-1.34

Conversation

@souleb

@souleb souleb commented Jun 9, 2026

Copy link
Copy Markdown

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Summary by CodeRabbit

  • Chores

    • Updated Kubernetes version to 1.34 and improved installation reliability with retry policies.
    • Updated system dependency download sources with enhanced error handling and retry mechanisms.
  • Bug Fixes

    • Fixed resource discovery to use correct plural forms for platform framework objects.

Signed-off-by: Soule BA <souleb@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates the container runtime build stage to Kubernetes 1.34 with improved system dependency installation reliability through curl retry mechanisms and apt retry policies, and updates the DOCA plugin to discover Kubernetes custom resources using plural API names instead of singular forms.

Changes

Container Runtime and Plugin Configuration Updates

Layer / File(s) Summary
Kubernetes version and dependency installation improvements
Dockerfile
Kubernetes version updated to 1.34; MFT (Mellanox Firmware Tools) download URLs changed from www.mellanox.com to content.mellanox.com; all downloads switched to curl with -fsSL flags and retry behavior; Kubernetes apt signing key fetch migrated from wget to curl with retries; apt-get operations configured with Acquire::Retries=3 for transient failure handling.
DOCA plugin resource discovery updates
sos/report/plugins/doca_dpf.py
Plugin docstring updated to reference dpuclusters (plural); DocaDpf.resources class attribute updated from singular to plural resource names (dpuclusterdpuclusters, dpuvolumeattachmentdpuvolumeattachments, dpfoperatorconfigdpfoperatorconfigs, etc.) with additional CRD types such as dpuservicenads and dpustoragepolicies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐇 A Docker leap to Kubernetes heights so bright,
With curl and retry shields against network's plight,
While DOCA's resources now stand in plural form,
Discovery flows true, by API's new norm! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updating the Kubernetes version (1.32→1.34 in Dockerfile) and updating the DPF plugin resource list (DocaDpf.resources in doca_dpf.py).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

54-57: ⚡ Quick win

Clarify the need for --allow-downgrades.

The --allow-downgrades flag permits installing older package versions than currently installed. In a fresh container build this is typically unnecessary and could mask dependency conflicts. Consider removing it unless there's a specific version pinning requirement.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` around lines 54 - 57, The RUN apt-get install command includes
the unnecessary --allow-downgrades flag; remove --allow-downgrades from the RUN
apt-get install invocation in the Dockerfile (the line starting "RUN apt-get
update ... && apt-get install -y") so the build won't permit downgrades by
default; if there is a deliberate need to force specific older package versions
instead, instead of leaving the flag, add an explicit comment and pin the
package versions in the same RUN command to make the requirement explicit.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Dockerfile`:
- Around line 54-57: The RUN apt-get install command includes the unnecessary
--allow-downgrades flag; remove --allow-downgrades from the RUN apt-get install
invocation in the Dockerfile (the line starting "RUN apt-get update ... &&
apt-get install -y") so the build won't permit downgrades by default; if there
is a deliberate need to force specific older package versions instead, instead
of leaving the flag, add an explicit comment and pin the package versions in the
same RUN command to make the requirement explicit.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fc2bda33-fa8f-4019-b9d5-b529f6efc1e3

📥 Commits

Reviewing files that changed from the base of the PR and between dcf8de6 and eb0483d.

📒 Files selected for processing (2)
  • Dockerfile
  • sos/report/plugins/doca_dpf.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant